Skip to content

Commit bab60d3

Browse files
committed
Fix usage of clang-tidy-review
1 parent 4f5b41e commit bab60d3

File tree

3 files changed

+3
-5
lines changed

3 files changed

+3
-5
lines changed

.clang-tidy

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,5 @@ Checks: '
1111
modernize-*,
1212
performance-*,
1313
portability-*,
14-
readability-*
1514
'
1615
WarningsAsErrors: ''

.github/workflows/clang-tidy-review.yml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,9 @@ jobs:
99
- uses: actions/setup-go@v4
1010
with:
1111
go-version: '>=1.18'
12-
- name: Build Project
13-
run: ./util/build_compilation_database.sh
1412
- uses: ZedThree/[email protected]
1513
with:
1614
split_workflow: true
17-
15+
clang_tidy_version: 19
16+
install_commands: /github/workspace/util/build_compilation_database.sh
1817
- uses: ZedThree/clang-tidy-review/[email protected]

util/build_compilation_database.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ TMP_DIR=`mktemp -d`
88
echo ${TMP_DIR}
99
AWS_LC_BUILD="${TMP_DIR}/AWS-LC-BUILD"
1010

11-
MY_CMAKE_FLAGS=("-GNinja" "-DCMAKE_BUILD_TYPE=Debug" "-DCMAKE_EXPORT_COMPILE_COMMANDS=ON")
11+
MY_CMAKE_FLAGS=("-DCMAKE_BUILD_TYPE=Debug" "-DCMAKE_EXPORT_COMPILE_COMMANDS=ON" "-DDISABLE_GO=ON")
1212

1313
mkdir -p "${AWS_LC_BUILD}"
1414

0 commit comments

Comments
 (0)