Skip to content

Commit bff0eaa

Browse files
authored
Fix clang tidy ci (#2375)
### Issues: Addresses P229174291 ### Description of changes: Fixes usage of clang-tidy-review: * Build needed to be performed inside docker image so that source files would have correct paths in the `compile_commands.json` Made changes to clang-tidy-review to preserve comments that are very close to lines in the diff * justsmth/clang-tidy-review@e8b24ea ### Testing: * I added a bad commit to this PR so that clang-tidy review would make a comment. See below. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.
1 parent 2f88b2d commit bff0eaa

File tree

3 files changed

+3
-5
lines changed

3 files changed

+3
-5
lines changed

.clang-tidy

-1
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,5 @@ Checks: '
1111
modernize-*,
1212
performance-*,
1313
portability-*,
14-
readability-*
1514
'
1615
WarningsAsErrors: ''

.github/workflows/clang-tidy-review.yml

+2-3
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,9 @@ jobs:
99
- uses: actions/setup-go@v4
1010
with:
1111
go-version: '>=1.18'
12-
- name: Build Project
13-
run: ./util/build_compilation_database.sh
1412
- uses: ZedThree/[email protected]
1513
with:
1614
split_workflow: true
17-
15+
clang_tidy_version: 19
16+
install_commands: /github/workspace/util/build_compilation_database.sh
1817
- uses: ZedThree/clang-tidy-review/[email protected]

util/build_compilation_database.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ TMP_DIR=`mktemp -d`
88
echo ${TMP_DIR}
99
AWS_LC_BUILD="${TMP_DIR}/AWS-LC-BUILD"
1010

11-
MY_CMAKE_FLAGS=("-GNinja" "-DCMAKE_BUILD_TYPE=Debug" "-DCMAKE_EXPORT_COMPILE_COMMANDS=ON")
11+
MY_CMAKE_FLAGS=("-DCMAKE_BUILD_TYPE=Debug" "-DCMAKE_EXPORT_COMPILE_COMMANDS=ON" "-DDISABLE_GO=ON")
1212

1313
mkdir -p "${AWS_LC_BUILD}"
1414

0 commit comments

Comments
 (0)