Add tests in DownloadDirectoryHelperTest and UploadDirectoryHelperTest to verify DIRECTORY_TRANSFER_MAX_CONCURRENCY

Signed-off-by: Andre Kurait <[email protected]>

Author: AndreKurait

services-custom/s3-transfer-manager/src/test/java/software/amazon/awssdk/transfer/s3/internal/DownloadDirectoryHelperTest.java

@@ -522,6 +522,47 @@ void downloadDirectory_withListObjectsRequestTransformer_transformerThrows_fails
         assertThatThrownBy(downloadDirectory.completionFuture()::join).hasCause(exception);
     }
 
+    @Test
+    void downloadDirectory_customMaxConcurrency_shouldRespectConfiguration() throws Exception {
+        // Create configuration with custom concurrency
+        TransferManagerConfiguration customConfig = TransferManagerConfiguration.builder()
+            .directoryTransferMaxConcurrency(75)  // Custom value
+            .build();
+        
+        DownloadDirectoryHelper customHelper = new DownloadDirectoryHelper(
+            customConfig, listObjectsHelper, singleDownloadFunction);
+        
+        // Set up mocks
+        stubSuccessfulListObjects(listObjectsHelper, "key1", "key2");
+        FileDownload fileDownload = newSuccessfulDownload();
+        when(singleDownloadFunction.apply(any(DownloadFileRequest.class)))
+            .thenReturn(fileDownload);
+        
+        // Execute download
+        DirectoryDownload downloadDirectory = customHelper.downloadDirectory(
+            DownloadDirectoryRequest.builder()
+                .destination(directory)
+                .bucket("bucket")
+                .build()
+        );
+        
+        // Verify it completes successfully
+        downloadDirectory.completionFuture().get(5, TimeUnit.SECONDS);
+        
+        // Verify the configuration value
+        assertThat(customConfig.option(TransferConfigurationOption.DIRECTORY_TRANSFER_MAX_CONCURRENCY))
+            .isEqualTo(75);
+    }
+
+    @Test
+    void downloadDirectory_defaultConfiguration_shouldUseDefaultConcurrency() {
+        TransferManagerConfiguration defaultConfig = TransferManagerConfiguration.builder().build();
+        
+        // Verify default value is 100
+        assertThat(defaultConfig.option(TransferConfigurationOption.DIRECTORY_TRANSFER_MAX_CONCURRENCY))
+            .isEqualTo(100);
+    }
+
     private static DefaultFileDownload completedDownload() {
         return new DefaultFileDownload(CompletableFuture.completedFuture(CompletedFileDownload.builder()
                                                                                               .response(GetObjectResponse.builder().build())

services-custom/s3-transfer-manager/src/test/java/software/amazon/awssdk/transfer/s3/internal/UploadDirectoryHelperTest.java

@@ -458,6 +458,44 @@ public void uploadDirectory_requestTransformFunctionThrows_failsUpload() {
         assertThatThrownBy(uploadFuture::join).getCause().hasCause(exception);
     }
 
+    @Test
+    void uploadDirectory_customMaxConcurrency_shouldRespectConfiguration() {
+        // Create configuration with custom concurrency
+        TransferManagerConfiguration customConfig = TransferManagerConfiguration.builder()
+            .directoryTransferMaxConcurrency(50)  // Custom value
+            .build();
+        
+        UploadDirectoryHelper customHelper = new UploadDirectoryHelper(customConfig, singleUploadFunction);
+        
+        // Set up mock responses
+        when(singleUploadFunction.apply(any(UploadFileRequest.class)))
+            .thenReturn(completedUpload());
+        
+        // Execute upload
+        DirectoryUpload uploadDirectory = customHelper.uploadDirectory(
+            UploadDirectoryRequest.builder()
+                .source(directory)
+                .bucket("bucket")
+                .build()
+        );
+        
+        // Verify it completes successfully
+        uploadDirectory.completionFuture().join();
+        
+        // Verify the configuration value
+        assertThat(customConfig.option(TransferConfigurationOption.DIRECTORY_TRANSFER_MAX_CONCURRENCY))
+            .isEqualTo(50);
+    }
+
+    @Test
+    void uploadDirectory_defaultConfiguration_shouldUseDefaultConcurrency() {
+        TransferManagerConfiguration defaultConfig = TransferManagerConfiguration.builder().build();
+        
+        // Verify default value is 100
+        assertThat(defaultConfig.option(TransferConfigurationOption.DIRECTORY_TRANSFER_MAX_CONCURRENCY))
+            .isEqualTo(100);
+    }
+
 
     private DefaultFileUpload completedUpload() {
         return new DefaultFileUpload(CompletableFuture.completedFuture(CompletedFileUpload.builder()