Description
Describe the issue
In your design for metrics and in the source code there exists an ErrorType metric. However it is a String which cannot be turned into a metric in the TimeBucketedMetrics class.
Since it is a String type, I believe it can only be used for Dimensions, which would mean I would have to extend the defaults to see it. But also, what metric would I use to alarm on if I had metrics with the error type dimension set? ApiCallSuccessful? But it wouldn't be successful so I'm just looking for the sample count of that?
The ErrorType also only gets recorded on exceptions here so unless the AWS service is failing I will never see ServerError metrics to create alarms for or know that I am graphing correctly. Ideally these metrics get collected with zeros on every call.
Ideally I think the ServerError and Throttling just become their own standard metrics which teams can create alarms on and it would also simplify the current approach of doing SampleCount - Sum for ApiCallSuccessful, which was the workaround proposed here #2711. Should also add ClientError to the list of possibilities.
ErrorType is not mentioned in metrics here https://docs.aws.amazon.com/sdk-for-java/latest/developer-guide/metrics-list.html implying it is a dimension, but again, those metrics won't exist unless the API's are failing.
Links
https://docs.aws.amazon.com/sdk-for-java/latest/developer-guide/metrics-list.html