Remove unncessary dependency and ignoredUnusedDeclaredDependency #6596
Conversation
| <!-- TODO(post-sra-identity-auth): With move to SRA Identity & Auth, most clients won't need a | ||
| dependency on auth module. But cannot remove it from services/pom.xml until all services | ||
| have switched. Some service modules may still need it, because they have tests that use the | ||
| old interfaces, but that should become a test scoped dependency in modules where needed. | ||
| And the line below removed. --> |
There was a problem hiding this comment.
We can't really remove auth dependency because that'd break customers who specify credentials provider directly (most of the customers)
http-auth, on the other hand, can be removed because it's a transitive dependency from authhttp-auth is required for services that support no op auth. Even though we could technically only add it for those services, it seems to less maintenance if we just add it for all services. For example, we may add other auth options in the future in http-auth module. Also, http-auth is pretty lightweight.
zoewangg
force-pushed
the
zoewang/fixTodosPart1
branch
2 times, most recently
from
5fdad7d to
d78430c
Compare
zoewangg
force-pushed
the
zoewang/fixTodosPart1
branch
from
d78430c to
840aa3e
Compare
|
|
This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one. |
2 participants
Motivation and Context
Remove unncessary dependency and ignoredUnusedDeclaredDependency