Skip to content

Remove unncessary dependency and ignoredUnusedDeclaredDependency #6596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 28, 2025
+1 −33
Merged

Remove unncessary dependency and ignoredUnusedDeclaredDependency #6596

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6024cea
Remove unncessary dependencies
zoewangg Nov 27, 2025
840aa3e
Address more TODOs
zoewangg Nov 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 1 addition & 15 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -542,17 +542,8 @@
<ignoredUnusedDeclaredDependency>software.amazon.awssdk:aws-sdk-java</ignoredUnusedDeclaredDependency>
<!-- Declared by the codegen maven plugins (lite and normal). Not used directly but used to override a transitive dependecy -->
<ignoredUnusedDeclaredDependency>org.codehaus.plexus:plexus-utils</ignoredUnusedDeclaredDependency>

<!-- TODO(post-sra-identity-auth): Once everything is switched to useSraAuth=true, remove this-->
<ignoredUnusedDeclaredDependency>software.amazon.awssdk:http-auth</ignoredUnusedDeclaredDependency>

<!-- TODO(post-sra-identity-auth): With move to SRA Identity & Auth, most clients won't need a
dependency on auth module. But cannot remove it from services/pom.xml until all services
have switched. Some service modules may still need it, because they have tests that use the
old interfaces, but that should become a test scoped dependency in modules where needed.
And the line below removed. -->
Comment on lines -549 to -553
Copy link
Contributor Author

@zoewangg zoewangg Nov 27, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't really remove auth dependency because that'd break customers who specify credentials provider directly (most of the customers)

http-auth, on the other hand, can be removed because it's a transitive dependency from auth, http-auth is required for services that support no op auth. Even though we could technically only add it for those services, it seems to less maintenance if we just add it for all services. For example, we may add other auth options in the future in http-auth module. Also, http-auth is pretty lightweight.

<ignoredUnusedDeclaredDependency>software.amazon.awssdk:auth</ignoredUnusedDeclaredDependency>

<ignoredUnusedDeclaredDependency>software.amazon.awssdk:http-auth</ignoredUnusedDeclaredDependency>
<!-- Ignoring any unused declared dependency warnings for access grants plugin across the bundle -->
<ignoredUnusedDeclaredDependency>software.amazon.s3.accessgrants:*</ignoredUnusedDeclaredDependency>
</ignoredUnusedDeclaredDependencies>
Expand Down Expand Up @@ -687,13 +678,8 @@
</includeModules>
<excludes>
<exclude>*.internal.*</exclude>
<!-- TODO remove after release -->
<exclude>software.amazon.awssdk.annotations.ReviewBeforeRelease</exclude>
<exclude>software.amazon.awssdk.thirdparty.*</exclude>
<exclude>software.amazon.awssdk.regions.*</exclude>
<exclude>software.amazon.awssdk.regions.*</exclude>
<exclude>software.amazon.awssdk.enhanced.dynamodb.mapper.annotations.DynamoDbSecondaryPartitionKey</exclude>
<exclude>software.amazon.awssdk.enhanced.dynamodb.mapper.annotations.DynamoDbSecondarySortKey</exclude>
</excludes>

<ignoreMissingOldVersion>true</ignoreMissingOldVersion>
Expand Down
8 changes: 0 additions & 8 deletions services/eventbridge/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,14 +67,6 @@
<version>${awsjavasdk.version}</version>
</dependency>
<!-- Test Dependencies -->
<!-- TODO(post-sra-identity-auth): auth-crt dependency can be removed as part of
cleanup after all services are on SRA -->
<dependency>
<groupId>software.amazon.awssdk</groupId>
<artifactId>auth-crt</artifactId>
<version>${awsjavasdk.version}</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>software.amazon.awssdk</groupId>
<artifactId>route53</artifactId>
Expand Down
5 changes: 0 additions & 5 deletions services/transcribestreaming/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,11 +52,6 @@
code that explicitly uses it -->
<ignoredUnusedDeclaredDependencies>
<ignoredUnusedDeclaredDependency>software.amazon.awssdk:http-auth-aws-eventstream</ignoredUnusedDeclaredDependency>

<!-- TODO(post-sra-identity-auth): Once this module is switched to useSraAuth=true, remove this-->
<!-- This ignore is already present in the root pom.xml, but seems like the
ignoredUnusedDeclaredDependencies aren't merged. So repeating it here. -->
<ignoredUnusedDeclaredDependency>software.amazon.awssdk:http-auth</ignoredUnusedDeclaredDependency>
</ignoredUnusedDeclaredDependencies>
</configuration>
</plugin>
Expand Down
5 changes: 0 additions & 5 deletions test/old-client-version-compatibility-test/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,11 +68,6 @@
<artifactId>auth</artifactId>
<version>${awsjavasdk.version}</version>
</dependency>
<dependency>
<groupId>software.amazon.awssdk</groupId>
<artifactId>http-auth</artifactId>
<version>${awsjavasdk.version}</version>
</dependency>
<dependency>
<groupId>software.amazon.awssdk</groupId>
<artifactId>http-client-spi</artifactId>
Expand Down
Loading