fix(core/protocols): rest-json default request body conditions #7501
+168
−56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuhe
commented
Nov 13, 2025
| async (args: InitializeHandlerArguments<any>): Promise<InitializeHandlerOutput<Output>> => { | ||
| const { input } = args; | ||
| if (input.accountId === undefined) { | ||
| if (!input.accountId) { |
Contributor
Author
There was a problem hiding this comment.
protocol tests say this should be inserted for both null and empty string, not only null.
kuhe
force-pushed
the
fix/rest-json
branch
4 times, most recently
from
8678c2c to
3ced966
Compare
smilkuri
approved these changes
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#7500
Description
This makes the preconditions for setting a default REST JSON request body of
{}more precise and consistent with older behavior.This relates to operations with httpPayload bindings where a falsy non-byte-array value is being used to represent an empty byte array.
Testing
Checklist
*.integ.spec.ts).@publictag and enable doc generation on the package?