Skip to content

Commit 9c6494a

Browse files
authored
added sample rule to beginSegmentWithSampling (#204)
1 parent 8992822 commit 9c6494a

File tree

2 files changed

+8
-1
lines changed

2 files changed

+8
-1
lines changed

aws-xray-recorder-sdk-core/src/main/java/com/amazonaws/xray/AWSXRayRecorder.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -405,7 +405,12 @@ public Segment beginSegmentWithSampling(String name) {
405405
final SamplingRequest samplingRequest = new SamplingRequest(name, null, null, null, this.origin);
406406
final SamplingResponse samplingResponse = this.getSamplingStrategy().shouldTrace(samplingRequest);
407407
if (samplingResponse.isSampled()) {
408-
return beginSegment(name);
408+
Segment segment = beginSegment(name);
409+
if (samplingResponse.getRuleName().isPresent()) {
410+
segment.setRuleName(samplingResponse.getRuleName().get());
411+
}
412+
413+
return segment;
409414
}
410415

411416
return beginNoOpSegment();

aws-xray-recorder-sdk-core/src/test/java/com/amazonaws/xray/AWSXRayRecorderTest.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -855,6 +855,8 @@ public void testBeginSegmentWithSamplingDoesSample() {
855855

856856
Segment segment = AWSXRay.beginSegmentWithSampling("test");
857857
assertThat(segment.isSampled()).isTrue();
858+
assertThat(segment.getAws().get("xray")).isInstanceOfSatisfying(
859+
Map.class, xray -> assertThat(xray.get("rule_name")).isEqualTo("rule"));
858860
}
859861

860862
@Test

0 commit comments

Comments
 (0)