Upgrade coverage to 5.x

[chanchiem]

Upgrading Coverage to 5.x breaks Travis CI and causes the following exception to occur at the end of the test:

No handlers could be found for logger "aws_xray_sdk.core.context"
Traceback (most recent call last):
  File "/Users/cssaete/PycharmProjects/XRaySDK/aws-xray-sdk-python/.tox/py27/bin/coverage", line 8, in <module>
    sys.exit(main())
  File "/Users/cssaete/PycharmProjects/XRaySDK/aws-xray-sdk-python/.tox/py27/lib/python2.7/site-packages/coverage/cmdline.py", line 824, in main
    status = CoverageScript().command_line(argv)
  File "/Users/cssaete/PycharmProjects/XRaySDK/aws-xray-sdk-python/.tox/py27/lib/python2.7/site-packages/coverage/cmdline.py", line 555, in command_line
    return self.do_run(options, args)
  File "/Users/cssaete/PycharmProjects/XRaySDK/aws-xray-sdk-python/.tox/py27/lib/python2.7/site-packages/coverage/cmdline.py", line 710, in do_run
    self.coverage.save()
  File "/Users/cssaete/PycharmProjects/XRaySDK/aws-xray-sdk-python/.tox/py27/lib/python2.7/site-packages/coverage/control.py", line 613, in save
    data = self.get_data()
  File "/Users/cssaete/PycharmProjects/XRaySDK/aws-xray-sdk-python/.tox/py27/lib/python2.7/site-packages/coverage/control.py", line 667, in get_data
    if self._collector and self._collector.flush_data():
  File "/Users/cssaete/PycharmProjects/XRaySDK/aws-xray-sdk-python/.tox/py27/lib/python2.7/site-packages/coverage/collector.py", line 429, in flush_data
    self.covdata.add_lines(self.mapped_file_dict(self.data))
  File "/Users/cssaete/PycharmProjects/XRaySDK/aws-xray-sdk-python/.tox/py27/lib/python2.7/site-packages/coverage/sqldata.py", line 436, in add_lines
    self._choose_lines_or_arcs(lines=True)
  File "/Users/cssaete/PycharmProjects/XRaySDK/aws-xray-sdk-python/.tox/py27/lib/python2.7/site-packages/coverage/sqldata.py", line 493, in _choose_lines_or_arcs
    with self._connect() as con:
  File "/Users/cssaete/PycharmProjects/XRaySDK/aws-xray-sdk-python/.tox/py27/lib/python2.7/site-packages/coverage/sqldata.py", line 298, in _connect
    self._create_db()
  File "/Users/cssaete/PycharmProjects/XRaySDK/aws-xray-sdk-python/.tox/py27/lib/python2.7/site-packages/coverage/sqldata.py", line 247, in _create_db
    with db:
  File "/Users/cssaete/PycharmProjects/XRaySDK/aws-xray-sdk-python/.tox/py27/lib/python2.7/site-packages/coverage/sqldata.py", line 1008, in __enter__
    self._connect()
  File "/Users/cssaete/PycharmProjects/XRaySDK/aws-xray-sdk-python/.tox/py27/lib/python2.7/site-packages/coverage/sqldata.py", line 996, in _connect
    self.execute("pragma journal_mode=off").close()
  File "/Users/cssaete/PycharmProjects/XRaySDK/aws-xray-sdk-python/.tox/py27/lib/python2.7/site-packages/coverage/sqldata.py", line 1025, in execute
    return self.con.execute(sql, parameters)
  File "/Users/cssaete/PycharmProjects/XRaySDK/aws-xray-sdk-python/aws_xray_sdk/ext/sqlite3/patch.py", line 32, in execute
    return self.cursor().execute(*args, **kwargs)
  File "/Users/cssaete/PycharmProjects/XRaySDK/aws-xray-sdk-python/aws_xray_sdk/core/models/subsegment.py", line 58, in __call__
    meta_processor=None,
  File "/Users/cssaete/PycharmProjects/XRaySDK/aws-xray-sdk-python/aws_xray_sdk/core/recorder.py", line 417, in record_subsegment
    subsegment = self.begin_subsegment(name, namespace)
  File "/Users/cssaete/PycharmProjects/XRaySDK/aws-xray-sdk-python/aws_xray_sdk/core/recorder.py", line 284, in begin_subsegment
    segment = self.current_segment()
  File "/Users/cssaete/PycharmProjects/XRaySDK/aws-xray-sdk-python/aws_xray_sdk/core/recorder.py", line 267, in current_segment
    entity = self.get_trace_entity()
  File "/Users/cssaete/PycharmProjects/XRaySDK/aws-xray-sdk-python/aws_xray_sdk/core/recorder.py", line 369, in get_trace_entity
    return self.context.get_trace_entity()
  File "/Users/cssaete/PycharmProjects/XRaySDK/aws-xray-sdk-python/aws_xray_sdk/core/context.py", line 93, in get_trace_entity
    return self.handle_context_missing()
  File "/Users/cssaete/PycharmProjects/XRaySDK/aws-xray-sdk-python/aws_xray_sdk/core/context.py", line 118, in handle_context_missing
    raise SegmentNotFoundException(MISSING_SEGMENT_MSG)
aws_xray_sdk.core.exceptions.exceptions.SegmentNotFoundException: cannot find the current segment/subsegment, please make sure you have a segment open

We will downgrade to 4.5.4 for now but will investigate what was introduced in 5.x that's causing the exception to occur.

[chanchiem]

From #195 (comment):
from @mikegrima

It's most likely related to: nedbat/coveragepy#889.
It caused breakage in https://github.com/spulec/moto (getmoto/moto#2638)

[chanchiem]

After discussion with the Coverage team, the change introduced in 5.0 is that they migrated from storing and fetching data from a JSON file to a SQLite database. Read more here.

What most likely is happening is that within the X-Ray sqlite test, it patches the sqlite3 package and runs its tests. After the tests are finished executing, code coverage is executed next, and when coverage creates a client to store/query data, no segment exists (this portion is usually created by X-Ray here) and then breaks. This must all be happening within the same python instance.

We need a mechanism to "unpatch" sqlite in the test.

[Syntactical01]

+1, this is an issue we just hit as well. Any update on this?

[janjur]

+1

[bhautikpip]

@janjur Can you provide more context about issues you're having? How are you encountering this issue while using X-Ray Python SDK? Have you upgraded coverage 5.x and builded SDK in your local environment?

[bblommers]

@bhautikpip For us, the issue occurs when trying to execute unit tests that call the X-Ray Python SDK.
This works fine with coverage 4.x, but breaks with coverage 5.x.

Tests are executed using this command:
pytest -sv --cov=moto --cov-report xml ./tests/test_xray

Resulting in the following stack traces:
https://github.com/bblommers/moto/runs/3422794651?check_suite_focus=true

[Divagnz]

+1, we are also facing this issue

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs in next 7 days. Thank you for your contributions.

[bblommers]

Thanks, stale-bot - this is still a relevant issue IMO though.

[timini]

any updates on this?