From 4e50ed4f935ca0164f42c6da10111ad0d15fa804 Mon Sep 17 00:00:00 2001
From: Wenhao Ji <predator.ray@gmail.com>
Date: Fri, 19 May 2023 09:53:39 -0700
Subject: [PATCH] Updated sample codes and also the ones on docs to follow the
 best practice for using Java String

---
 doc_source/java-context.md                           |  6 +++---
 doc_source/java-handler.md                           |  2 +-
 doc_source/java-logging.md                           |  2 +-
 .../src/test/java/example/TestContext.java           | 12 ++++++------
 .../src/test/java/example/TestContext.java           | 12 ++++++------
 .../src/main/java/example/Handler.java               |  2 +-
 .../src/main/java/example/HandlerDynamoDB.java       |  2 +-
 .../src/main/java/example/HandlerKinesis.java        |  2 +-
 .../src/test/java/example/TestContext.java           | 12 ++++++------
 .../src/test/java/example/TestContext.java           | 12 ++++++------
 .../s3-java/src/test/java/example/TestContext.java   | 12 ++++++------
 11 files changed, 38 insertions(+), 38 deletions(-)

diff --git a/doc_source/java-context.md b/doc_source/java-context.md
index f5e46aff..b1fb8ea8 100644
--- a/doc_source/java-context.md
+++ b/doc_source/java-context.md
@@ -33,7 +33,7 @@ public class Handler implements RequestHandler<Map<String,String>, String>{
   public String handleRequest(Map<String,String> event, Context context)
   {
     LambdaLogger logger = context.getLogger();
-    String response = new String("200 OK");
+    String response = "200 OK";
     // log execution details
     logger.log("ENVIRONMENT VARIABLES: " + gson.toJson(System.getenv()));
     logger.log("CONTEXT: " + gson.toJson(context));
@@ -79,10 +79,10 @@ import [com\.amazonaws\.services\.lambda\.runtime\.LambdaLogger](https://github.
 public class TestContext implements Context{
   public TestContext() {}
   public String getAwsRequestId(){
-    return new String("495b12a8-xmpl-4eca-8168-160484189f99");
+    return "495b12a8-xmpl-4eca-8168-160484189f99";
   }
   public String getLogGroupName(){
-    return new String("/aws/lambda/my-function");
+    return "/aws/lambda/my-function";
   }
   ...
   public LambdaLogger getLogger(){
diff --git a/doc_source/java-handler.md b/doc_source/java-handler.md
index 0d1249d4..2013f6a7 100644
--- a/doc_source/java-handler.md
+++ b/doc_source/java-handler.md
@@ -20,7 +20,7 @@ public class Handler implements RequestHandler<Map<String,String>, String>{
   public String handleRequest(Map<String,String> event, Context context)
   {
     LambdaLogger logger = context.getLogger();
-    String response = new String("200 OK");
+    String response = "200 OK";
     // log execution details
     logger.log("ENVIRONMENT VARIABLES: " + gson.toJson(System.getenv()));
     logger.log("CONTEXT: " + gson.toJson(context));
diff --git a/doc_source/java-logging.md b/doc_source/java-logging.md
index 4a43b225..37b40cfe 100644
--- a/doc_source/java-logging.md
+++ b/doc_source/java-logging.md
@@ -29,7 +29,7 @@ public class Handler implements RequestHandler<Object, String>{
   public String handleRequest(Object event, Context context)
   {
     LambdaLogger logger = context.getLogger();
-    String response = new String("SUCCESS");
+    String response = "SUCCESS";
     // log execution details
     logger.log("ENVIRONMENT VARIABLES: " + gson.toJson(System.getenv()));
     logger.log("CONTEXT: " + gson.toJson(context));
diff --git a/sample-apps/blank-java/src/test/java/example/TestContext.java b/sample-apps/blank-java/src/test/java/example/TestContext.java
index 69e0af00..77c4a59e 100644
--- a/sample-apps/blank-java/src/test/java/example/TestContext.java
+++ b/sample-apps/blank-java/src/test/java/example/TestContext.java
@@ -9,22 +9,22 @@ public class TestContext implements Context{
 
   public TestContext() {}
   public String getAwsRequestId(){
-    return new String("495b12a8-xmpl-4eca-8168-160484189f99");
+    return "495b12a8-xmpl-4eca-8168-160484189f99";
   }
   public String getLogGroupName(){
-    return new String("/aws/lambda/my-function");
+    return "/aws/lambda/my-function";
   }
   public String getLogStreamName(){
-    return new String("2020/02/26/[$LATEST]704f8dxmpla04097b9134246b8438f1a");
+    return "2020/02/26/[$LATEST]704f8dxmpla04097b9134246b8438f1a";
   }
   public String getFunctionName(){
-    return new String("my-function");
+    return "my-function";
   }
   public String getFunctionVersion(){
-    return new String("$LATEST");
+    return "$LATEST";
   }
   public String getInvokedFunctionArn(){
-    return new String("arn:aws:lambda:us-east-2:123456789012:function:my-function");
+    return "arn:aws:lambda:us-east-2:123456789012:function:my-function";
   }
   public CognitoIdentity getIdentity(){
     return null;
diff --git a/sample-apps/java-basic/src/test/java/example/TestContext.java b/sample-apps/java-basic/src/test/java/example/TestContext.java
index 69e0af00..77c4a59e 100644
--- a/sample-apps/java-basic/src/test/java/example/TestContext.java
+++ b/sample-apps/java-basic/src/test/java/example/TestContext.java
@@ -9,22 +9,22 @@ public class TestContext implements Context{
 
   public TestContext() {}
   public String getAwsRequestId(){
-    return new String("495b12a8-xmpl-4eca-8168-160484189f99");
+    return "495b12a8-xmpl-4eca-8168-160484189f99";
   }
   public String getLogGroupName(){
-    return new String("/aws/lambda/my-function");
+    return "/aws/lambda/my-function";
   }
   public String getLogStreamName(){
-    return new String("2020/02/26/[$LATEST]704f8dxmpla04097b9134246b8438f1a");
+    return "2020/02/26/[$LATEST]704f8dxmpla04097b9134246b8438f1a";
   }
   public String getFunctionName(){
-    return new String("my-function");
+    return "my-function";
   }
   public String getFunctionVersion(){
-    return new String("$LATEST");
+    return "$LATEST";
   }
   public String getInvokedFunctionArn(){
-    return new String("arn:aws:lambda:us-east-2:123456789012:function:my-function");
+    return "arn:aws:lambda:us-east-2:123456789012:function:my-function";
   }
   public CognitoIdentity getIdentity(){
     return null;
diff --git a/sample-apps/java-events-v1sdk/src/main/java/example/Handler.java b/sample-apps/java-events-v1sdk/src/main/java/example/Handler.java
index 6ec8c54d..2e29f105 100644
--- a/sample-apps/java-events-v1sdk/src/main/java/example/Handler.java
+++ b/sample-apps/java-events-v1sdk/src/main/java/example/Handler.java
@@ -19,7 +19,7 @@ public class Handler implements RequestHandler<S3Event, String>{
   @Override
   public String handleRequest(S3Event event, Context context)
   {
-    String response = new String("200 OK");
+    String response = "200 OK";
     S3EventNotificationRecord record = event.getRecords().get(0);
     String srcBucket = record.getS3().getBucket().getName();
     // Object key may have spaces or unicode non-ASCII characters.
diff --git a/sample-apps/java-events-v1sdk/src/main/java/example/HandlerDynamoDB.java b/sample-apps/java-events-v1sdk/src/main/java/example/HandlerDynamoDB.java
index da0c0281..821cad28 100644
--- a/sample-apps/java-events-v1sdk/src/main/java/example/HandlerDynamoDB.java
+++ b/sample-apps/java-events-v1sdk/src/main/java/example/HandlerDynamoDB.java
@@ -18,7 +18,7 @@ public class HandlerDynamoDB implements RequestHandler<DynamodbEvent, String>{
   @Override
   public String handleRequest(DynamodbEvent event, Context context)
   {
-    String response = new String("200 OK");
+    String response = "200 OK";
     for (DynamodbStreamRecord record : event.getRecords()){
       logger.info(record.getEventID());
       logger.info(record.getEventName());
diff --git a/sample-apps/java-events-v1sdk/src/main/java/example/HandlerKinesis.java b/sample-apps/java-events-v1sdk/src/main/java/example/HandlerKinesis.java
index e46720df..537e758f 100644
--- a/sample-apps/java-events-v1sdk/src/main/java/example/HandlerKinesis.java
+++ b/sample-apps/java-events-v1sdk/src/main/java/example/HandlerKinesis.java
@@ -18,7 +18,7 @@ public class HandlerKinesis implements RequestHandler<KinesisEvent, String>{
   @Override
   public String handleRequest(KinesisEvent event, Context context)
   {
-    String response = new String("200 OK");
+    String response = "200 OK";
     for(KinesisEventRecord record : event.getRecords()) {
       logger.info(gson.toJson(record.getKinesis().getData()));
     }
diff --git a/sample-apps/java-events-v1sdk/src/test/java/example/TestContext.java b/sample-apps/java-events-v1sdk/src/test/java/example/TestContext.java
index 69e0af00..77c4a59e 100644
--- a/sample-apps/java-events-v1sdk/src/test/java/example/TestContext.java
+++ b/sample-apps/java-events-v1sdk/src/test/java/example/TestContext.java
@@ -9,22 +9,22 @@ public class TestContext implements Context{
 
   public TestContext() {}
   public String getAwsRequestId(){
-    return new String("495b12a8-xmpl-4eca-8168-160484189f99");
+    return "495b12a8-xmpl-4eca-8168-160484189f99";
   }
   public String getLogGroupName(){
-    return new String("/aws/lambda/my-function");
+    return "/aws/lambda/my-function";
   }
   public String getLogStreamName(){
-    return new String("2020/02/26/[$LATEST]704f8dxmpla04097b9134246b8438f1a");
+    return "2020/02/26/[$LATEST]704f8dxmpla04097b9134246b8438f1a";
   }
   public String getFunctionName(){
-    return new String("my-function");
+    return "my-function";
   }
   public String getFunctionVersion(){
-    return new String("$LATEST");
+    return "$LATEST";
   }
   public String getInvokedFunctionArn(){
-    return new String("arn:aws:lambda:us-east-2:123456789012:function:my-function");
+    return "arn:aws:lambda:us-east-2:123456789012:function:my-function";
   }
   public CognitoIdentity getIdentity(){
     return null;
diff --git a/sample-apps/java-events/src/test/java/example/TestContext.java b/sample-apps/java-events/src/test/java/example/TestContext.java
index 69e0af00..77c4a59e 100644
--- a/sample-apps/java-events/src/test/java/example/TestContext.java
+++ b/sample-apps/java-events/src/test/java/example/TestContext.java
@@ -9,22 +9,22 @@ public class TestContext implements Context{
 
   public TestContext() {}
   public String getAwsRequestId(){
-    return new String("495b12a8-xmpl-4eca-8168-160484189f99");
+    return "495b12a8-xmpl-4eca-8168-160484189f99";
   }
   public String getLogGroupName(){
-    return new String("/aws/lambda/my-function");
+    return "/aws/lambda/my-function";
   }
   public String getLogStreamName(){
-    return new String("2020/02/26/[$LATEST]704f8dxmpla04097b9134246b8438f1a");
+    return "2020/02/26/[$LATEST]704f8dxmpla04097b9134246b8438f1a";
   }
   public String getFunctionName(){
-    return new String("my-function");
+    return "my-function";
   }
   public String getFunctionVersion(){
-    return new String("$LATEST");
+    return "$LATEST";
   }
   public String getInvokedFunctionArn(){
-    return new String("arn:aws:lambda:us-east-2:123456789012:function:my-function");
+    return "arn:aws:lambda:us-east-2:123456789012:function:my-function";
   }
   public CognitoIdentity getIdentity(){
     return null;
diff --git a/sample-apps/s3-java/src/test/java/example/TestContext.java b/sample-apps/s3-java/src/test/java/example/TestContext.java
index 69e0af00..77c4a59e 100644
--- a/sample-apps/s3-java/src/test/java/example/TestContext.java
+++ b/sample-apps/s3-java/src/test/java/example/TestContext.java
@@ -9,22 +9,22 @@ public class TestContext implements Context{
 
   public TestContext() {}
   public String getAwsRequestId(){
-    return new String("495b12a8-xmpl-4eca-8168-160484189f99");
+    return "495b12a8-xmpl-4eca-8168-160484189f99";
   }
   public String getLogGroupName(){
-    return new String("/aws/lambda/my-function");
+    return "/aws/lambda/my-function";
   }
   public String getLogStreamName(){
-    return new String("2020/02/26/[$LATEST]704f8dxmpla04097b9134246b8438f1a");
+    return "2020/02/26/[$LATEST]704f8dxmpla04097b9134246b8438f1a";
   }
   public String getFunctionName(){
-    return new String("my-function");
+    return "my-function";
   }
   public String getFunctionVersion(){
-    return new String("$LATEST");
+    return "$LATEST";
   }
   public String getInvokedFunctionArn(){
-    return new String("arn:aws:lambda:us-east-2:123456789012:function:my-function");
+    return "arn:aws:lambda:us-east-2:123456789012:function:my-function";
   }
   public CognitoIdentity getIdentity(){
     return null;