Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing the entry field to be changed #2687

Open
Quest79 opened this issue Jan 24, 2024 · 3 comments
Open

Allowing the entry field to be changed #2687

Quest79 opened this issue Jan 24, 2024 · 3 comments

Comments

@Quest79
Copy link

Quest79 commented Jan 24, 2024

I see no way to duplicate or copy entire entries? This would be a great feature if this isnt hidden somewhere already.

Ive tried to copy and past on this screen
And edit the ID on this screen manually to execute.

Neither option works when you just want to add an new entry to a table using the structure of another entry

@Helias
Copy link
Member

Helias commented Jan 24, 2024

it's a bit hard to do, so for now we did not implement it
this feature request has been alreadu reported here #25 so I am closing this issue

thanks anyway for the report

@Helias Helias closed this as completed Jan 24, 2024
@Quest79
Copy link
Author

Quest79 commented Jan 24, 2024

it's a bit hard to do, so for now we did not implement it this feature request has been alreadu reported here #25 so I am closing this issue

thanks anyway for the report

Can you explain a little why this would be hard to do?
All that is needed is the ID to be editable. SQL will take care of the rest.

The ID not being editable forces the user to have to copy the already made code by hand, edit the ID by hand, and run it in an HeidiSQL by hand. This seems weird as Keira3 was made to not have to do that.

@FrancescoBorzi FrancescoBorzi changed the title Duplicate Entry Allowing the entry field to be changed Feb 2, 2024
@FrancescoBorzi FrancescoBorzi reopened this Feb 2, 2024
@FrancescoBorzi
Copy link
Collaborator

Reopening this and editing the title. Allowing the entry to be changed is a separate feature request than a full entity copy.

But be aware that allowing the entry to be changed may easily lead to an inconsistent state of the editor.

However, if you know what you are doing, I don't see a problem allowing it.

The reason is the same for

Can you explain a little why this would be hard to do?

The reason that the full copy is hard to do is because you have to sync all dependant tables.

For example, if you chance creature_template.entry you need to also sync all other tables that point to that value, e.g. creature_template_addon and so on. If you know what you are doing and you manually do it, I don't see any problems in allowing you to do it. Otherwise, you might just mess up things.

I'm not considering allowing this feature behind some kind of "I know what I'm doing" toggle, but this needs a second look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants