Merge pull request #178 from backstage/rugvip/draft

pr-automation: lower score for draft PRs or PRs not passing checks

Author: Rugvip

pr-automation/collectInput.ts

@@ -39,6 +39,7 @@ const QUERY = `
       pullRequest(number: $issueNumber) {
         number
         title
+        isDraft
         reviewDecision
         author {
           login
@@ -47,6 +48,9 @@ const QUERY = `
           target {
             ... on Commit {
               committedDate
+              statusCheckRollup {
+                state
+              }
             }
           }
         }
@@ -324,13 +328,31 @@ async function getPrAutomationData(
     | 'REVIEW_REQUIRED'
     | undefined;
 
-  const headCommitDate = (
-    pr as { headRef?: { target?: { committedDate?: string } } }
-  ).headRef?.target?.committedDate;
+  const headCommit = (
+    pr as {
+      headRef?: {
+        target?: {
+          committedDate?: string;
+          statusCheckRollup?: { state?: string };
+        };
+      };
+    }
+  ).headRef?.target;
+
+  const headCommitDate = headCommit?.committedDate;
+  const checkStatus = headCommit?.statusCheckRollup?.state as
+    | 'SUCCESS'
+    | 'FAILURE'
+    | 'PENDING'
+    | 'ERROR'
+    | 'EXPECTED'
+    | undefined;
 
   return {
     number: pr.number,
     title: pr.title,
+    isDraft: (pr as { isDraft?: boolean }).isDraft ?? false,
+    checkStatus,
     authorLogin: pr.author?.login ?? undefined,
     reviewDecision,
     labels:

pr-automation/main.ts

@@ -176,9 +176,19 @@ export async function main() {
   // Get copilot review priority boost
   const copilotPriority = getCopilotReviewPriority(data.reviews);
 
-  const priority = basePriority + authorScore + copilotPriority;
+  // Apply penalty multipliers for draft PRs (20%) and failing checks (50%)
+  const draftMultiplier = data.isDraft ? 0.2 : 1;
+  const checksPassing = data.checkStatus === 'SUCCESS';
+  const checksMultiplier = checksPassing ? 1 : 0.5;
+  const priority = Math.round(
+    (basePriority + authorScore + copilotPriority) *
+      draftMultiplier *
+      checksMultiplier,
+  );
 
   const priorityParts: string[] = [];
+  if (data.isDraft) priorityParts.push('draft ×0.2');
+  if (!checksPassing) priorityParts.push(`checks ${data.checkStatus} ×0.5`);
   if (reviewerApproved) priorityParts.push('reviewer approval');
   if (authorScore > 0) priorityParts.push(`author score +${authorScore}`);
   if (copilotPriority > 0) priorityParts.push(`copilot +${copilotPriority}`);

pr-automation/types.ts

@@ -41,9 +41,18 @@ export interface Comment {
   createdAt?: string;
 }
 
+export type CheckStatusState =
+  | 'SUCCESS'
+  | 'FAILURE'
+  | 'PENDING'
+  | 'ERROR'
+  | 'EXPECTED';
+
 export interface PrData {
   number: number;
   title: string;
+  isDraft: boolean;
+  checkStatus?: CheckStatusState;
   authorLogin?: string;
   reviewDecision?: 'APPROVED' | 'CHANGES_REQUESTED' | 'REVIEW_REQUIRED';
   labels: string[];