chore: Removing default imagePullPolicy to honor Kubernetes defaults (#287)

* Removing pullPolicy by default, so that default K8s behaviour is applied

Signed-off-by: Leanne Ahern <[email protected]>

* Bumping Chart.yaml based on change - patch

Signed-off-by: Leanne Ahern <[email protected]>

* Setting pullPolicy to empty string

Signed-off-by: Leanne Ahern <[email protected]>

* Updating schema and running pre-commits

Signed-off-by: Leanne Ahern <[email protected]>

* Updating schema to allow all docs options

Signed-off-by: Leanne Ahern <[email protected]>

* updating branch

Signed-off-by: Leanne Ahern <[email protected]>

---------

Signed-off-by: Leanne Ahern <[email protected]>

Author: OpinionatedHeron

charts/backstage/Chart.yaml

@@ -38,4 +38,4 @@ sources:
 # This is the chart version. This version number should be incremented each time you make changes
 # to the chart and its templates, including the app version.
 # Versions are expected to follow Semantic Versioning (https://semver.org/)
-version: 2.6.2
+version: 2.6.3

charts/backstage/README.md

@@ -2,7 +2,7 @@
 # Backstage Helm Chart
 
 [![Artifact Hub](https://img.shields.io/endpoint?url=https://artifacthub.io/badge/repository/backstage)](https://artifacthub.io/packages/search?repo=backstage)
-![Version: 2.6.2](https://img.shields.io/badge/Version-2.6.2-informational?style=flat-square)
+![Version: 2.6.3](https://img.shields.io/badge/Version-2.6.3-informational?style=flat-square)
 ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square)
 
 A Helm chart for deploying a Backstage application
@@ -131,7 +131,7 @@ Kubernetes: `>= 1.19.0-0`
 | backstage.extraVolumes | Backstage container additional volumes | list | `[]` |
 | backstage.hostAliases | Host Aliases for the pod <br /> Ref: https://kubernetes.io/docs/concepts/services-networking/add-entries-to-pod-etc-hosts-with-host-aliases/ | list | `[]` |
 | backstage.image.digest | Backstage image digest (digest takes precedence over image tag) | string | `""` |
-| backstage.image.pullPolicy | Specify a imagePullPolicy. Defaults to 'Always' if image tag is 'latest', else set to 'IfNotPresent' <br /> Ref: https://kubernetes.io/docs/concepts/containers/images/#image-pull-policy | string | `"Always"` |
+| backstage.image.pullPolicy | Specify a imagePullPolicy. Defaults to 'Always' if image tag is 'latest', else set to 'IfNotPresent' <br /> Ref: https://kubernetes.io/docs/concepts/containers/images/#image-pull-policy | string | `""` |
 | backstage.image.pullSecrets | Optionally specify an array of imagePullSecrets.  Secrets must be manually created in the namespace. <br /> Ref: https://kubernetes.io/docs/tasks/configure-pod-container/pull-image-private-registry/ <br /> E.g: `pullSecrets: [myRegistryKeySecretName]` | list | `[]` |
 | backstage.image.registry | Backstage image registry | string | `"ghcr.io"` |
 | backstage.image.repository | Backstage image repository | string | `"backstage/backstage"` |

charts/backstage/values.schema.json

@@ -4091,11 +4091,13 @@
                             "type": "string"
                         },
                         "pullPolicy": {
-                            "default": "Always",
+                            "default": "",
                             "description": "Ref: https://kubernetes.io/docs/concepts/containers/images/#image-pull-policy",
                             "enum": [
                                 "Always",
-                                "IfNotPresent"
+                                "IfNotPresent",
+                                "Never",
+                                ""
                             ],
                             "title": "Specify a imagePullPolicy.",
                             "type": "string"

charts/backstage/values.schema.tmpl.json

@@ -255,10 +255,12 @@
                             "title": "Specify a imagePullPolicy.",
                             "description": "Ref: https://kubernetes.io/docs/concepts/containers/images/#image-pull-policy",
                             "type": "string",
-                            "default": "Always",
+                            "default": "",
                             "enum": [
                                 "Always",
-                                "IfNotPresent"
+                                "IfNotPresent",
+                                "Never",
+                                ""
                             ]
                         },
                         "pullSecrets": {

charts/backstage/values.yaml

@@ -125,7 +125,7 @@ backstage:
     # -- Specify a imagePullPolicy.
     # Defaults to 'Always' if image tag is 'latest', else set to 'IfNotPresent'
     # <br /> Ref: https://kubernetes.io/docs/concepts/containers/images/#image-pull-policy
-    pullPolicy: Always
+    pullPolicy: ""
 
     # -- Optionally specify an array of imagePullSecrets.
     #  Secrets must be manually created in the namespace.