Missing </div> when index.html is generated with org-static-blog-enable-tags set to nil

[Scrofff]

When index.html is generated with org-static-blog-enable-tags set to nil an empty taglist is generated, leading to elements <div class="taglist"> being generated without a corresponding </div>

Sorry for bombing your tracker, I wouldn't have come across this issue if I hadn't run into the previous one. Needless to say, I'm loving how usable org-static-blog is and intend to use it when blogging inspiration strikes

[Scrofff]

Having just tried the 1.4.0 release, where tags are generated correctly, I've found that the blog posts themselves have elements <div class="taglist"> and corresponding </div> generated correctly, but the generated files (index.html et al) don't have the closing tag.

I'm on emacs 27.1 with org-20201116, installed from elpa

[bastibe]

Thank you for the bug report. I currently do not have a lot of time to put into org-static-blog, or any OSS development. Would you like to look into this and create a pull request? I would be grateful for the help!

[Scrofff]

I'm similarly bereft of spare time and can't see myself having time to dig deeply into it until around Christmas, though I'd like to help if I can.

I quickly scanned the source of your blog and a couple of the others you linked and saw that they did not have this bug so I'm thinking that maybe there's some weird interaction going on with the versions of this package, emacs and org that I'm using - which would be tricky indeed to track down... The configuration I'm using is a copy-paste of yours with my paths etc in the strings so I'm confident it's not a configuration error.

If and when I find out more, I'll drop a note here

[adithyaov]

I'm currently looking at the code right now. This should not be happening. I'll debug it and get back to you.

[adithyaov]

@Scrofff I've just generated the files and am unable to reproduce your problem I see a properly closed div.

[Scrofff]

Thanks for looking into it! I've dug a bit deeper and concentrated on how my config differed from bastibe's and I've isolated it to org-static-blog-post-comments

When I have
(setq org-static-blog-post-comments "")
in my config then the div is closed properly, but if the string is not empty, even if it just a space, like
(setq org-static-blog-post-comments " ")
then it is not closed properly!

[adithyaov]

Ah, I see.

The problem seems to be with parsing.
We should probably introduce some dummy HTML elements in the post for more stable parsing.

Will send a fix.

[hellwolf]

it seems similar to #113 ?