Skip to content

Commit bb97b3a

Browse files
committed
FIx TransformedAdaptiveMHTuning and example
1 parent 9cb2625 commit bb97b3a

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

examples/dev-internal/transformed_example.jl

+3-3
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ using BAT.LinearAlgebra
66
using BAT.Distributions
77
using BAT.InverseFunctions
88
import BAT: TransformedMCMCIterator, TransformedAdaptiveMHTuning, TransformedRAMTuner, TransformedMHProposal, TransformedNoTransformedMCMCTempering, transformed_mcmc_step!!, TransformedMCMCTransformedSampleID
9-
using Random123
9+
using Random123, PositiveFactorizations
1010
using AutoDiffOperators
1111

1212
import BAT: mcmc_iterate!, transformed_mcmc_iterate!, TransformedMCMCSampling
@@ -23,8 +23,8 @@ my_result = @time BAT.bat_sample_impl(posterior, TransformedMCMCSampling(pre_tra
2323
density_notrafo = convert(BAT.AbstractMeasureOrDensity, posterior)
2424
density, trafo = BAT.transform_and_unshape(PriorToGaussian(), density_notrafo)
2525

26-
c = BAT._approx_cov(density)
27-
f = BAT.CustomTransform(Mul(c))
26+
s = cholesky(Positive, BAT._approx_cov(density)).L
27+
f = BAT.CustomTransform(Mul(s))
2828

2929
my_result = @time BAT.bat_sample_impl(posterior, TransformedMCMCSampling(pre_transform=PriorToGaussian(), tuning_alg=TransformedAdaptiveMHTuning(), nchains=4, nsteps=4*100000, adaptive_transform=f), context)
3030

src/samplers/transformed_mcmc/mcmc_tuning/mcmc_proposalcov_tuner.jl

+1-1
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ end
5858

5959
# this function is called once after each tuning cycle
6060
g_state = nothing
61-
function tuning_update!(tuner::TransformedProposalCovTuner, chain::MCMCIterator, samples::DensitySampleVector)
61+
function tuning_update!(tuner::TransformedProposalCovTuner, chain::TransformedMCMCIterator, samples::DensitySampleVector)
6262
global g_state = (;tuner, chain)
6363

6464
stats = tuner.stats

0 commit comments

Comments
 (0)