Automatically download correct .Net SDK packs (#426)

This change removes the `targeting_packs` and `runtime_packs` attributes from all rules and now all packs are automatically inferred from the project SDK, target framework and runtime identifier for a target.

Author: purkhusid

.bazelci/presubmit.yml

@@ -1,12 +1,12 @@
 ---
 buildifier:
-  version: 6.3.3
+  version: 7.1.0
 
 matrix:
-  platform: ["windows", "ubuntu1804", "rbe_ubuntu1604", "macos"]
+  platform: ["windows", "ubuntu1804", "rbe_ubuntu1604", "macos", "macos_arm64", "ubuntu2004_arm64", "windows_arm64"]
   working_directory: ["", "examples"]
   strict_deps: ["--@rules_dotnet//dotnet/settings:strict_deps=true", "--@rules_dotnet//dotnet/settings:strict_deps=false"]
-  flag_combo: [["--enable_bzlmod", "--@rules_dotnet//dotnet/settings:strict_deps=true"], ["--enable_bzlmod", "--@rules_dotnet//dotnet/settings:strict_deps=false"], ["--noenable_bzlmod", "--@rules_dotnet//dotnet/settings:strict_deps=true"], ["--noenable_bzlmod", "--@rules_dotnet//dotnet/settings:strict_deps=false"]]
+  flag_combo: [["--enable_bzlmod", "--@rules_dotnet//dotnet/settings:strict_deps=true"], ["--enable_bzlmod", "--@rules_dotnet//dotnet/settings:strict_deps=false"]]
   e2e_working_directory: ["e2e/net6.0", "e2e/net7.0", "e2e/net8.0"]
 
 tasks:

.bazelversion

@@ -1 +1 @@
-7.1.0
+7.1.1

.devcontainer/Dockerfile

@@ -22,17 +22,17 @@ RUN curl -o $HOME/bin/bazelisk-linux-$TARGETARCH -fsSL https://github.com/bazelb
   && ln -s $HOME/bin/bazelisk $HOME/bin/bazel
 
 # Install bazel-watcher
-RUN curl -o $HOME/bin/ibazel_linux_$TARGETARCH -fsSL https://github.com/bazelbuild/bazel-watcher/releases/download/v0.24.0/ibazel_linux_$TARGETARCH \
+RUN curl -o $HOME/bin/ibazel_linux_$TARGETARCH -fsSL https://github.com/bazelbuild/bazel-watcher/releases/download/v0.25.1/ibazel_linux_$TARGETARCH \
   && mv $HOME/bin/ibazel_linux_$TARGETARCH $HOME/bin/ibazel \
   && chmod +x $HOME/bin/ibazel
 
 # Install buildifier
-RUN curl -o $HOME/bin/buildifier-linux-$TARGETARCH -fsSL https://github.com/bazelbuild/buildtools/releases/download/v6.4.0/buildifier-linux-$TARGETARCH \
+RUN curl -o $HOME/bin/buildifier-linux-$TARGETARCH -fsSL https://github.com/bazelbuild/buildtools/releases/download/v7.1.0/buildifier-linux-$TARGETARCH \
   && mv $HOME/bin/buildifier-linux-$TARGETARCH $HOME/bin/buildifier \
   && chmod +x $HOME/bin/buildifier
 
 # Install buildozer
-RUN curl -o $HOME/bin/buildozer-linux-$TARGETARCH -fsSL https://github.com/bazelbuild/buildtools/releases/download/v6.4.0/buildozer-linux-$TARGETARCH \
+RUN curl -o $HOME/bin/buildozer-linux-$TARGETARCH -fsSL https://github.com/bazelbuild/buildtools/releases/download/v7.1.0/buildozer-linux-$TARGETARCH \
   && mv $HOME/bin/buildozer-linux-$TARGETARCH $HOME/bin/buildozer \
   && chmod +x $HOME/bin/buildozer
 

.github/workflows/release_prep.sh

@@ -16,47 +16,23 @@ git archive --format=tar --prefix=${PREFIX}/ ${TAG} | gzip > $ARCHIVE
 SHA=$(shasum -a 256 $ARCHIVE | awk '{print $1}')
 
 cat << EOF
-## Using Bzlmod with Bazel 7 (We require Bazel 7 and above)
+## Using Bzlmod with Bazel 7 and above
+
+Requirements:
+* Bazel 7.0.0 or later
+* Bzlmod must be enabled
 
 1. Add to your \`MODULE.bazel\` file:
 
 \`\`\`starlark
 bazel_dep(name = "rules_dotnet", version = "${TAG:1}")
 
 dotnet = use_extension("@rules_dotnet//dotnet:extensions.bzl", "dotnet")
-dotnet.toolchain(dotnet_version = "8.0.100")
+dotnet.toolchain(dotnet_version = "8.0.200")
 use_repo(dotnet, "dotnet_toolchains")
 
 register_toolchains("@dotnet_toolchains//:all")
 
 \`\`\`
 
-## Using WORKSPACE
-
-Paste this snippet into your `WORKSPACE.bazel` file:
-
-\`\`\`starlark
-load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
-http_archive(
-    name = "rules_dotnet",
-    sha256 = "${SHA}",
-    strip_prefix = "${PREFIX}",
-    url = "https://github.com/bazelbuild/rules_dotnet/releases/download/${TAG}/${ARCHIVE}",
-)
-
-load(
-    "@rules_dotnet//dotnet:repositories.bzl",
-    "dotnet_register_toolchains",
-    "rules_dotnet_dependencies",
-)
-
-rules_dotnet_dependencies()
-
-# Here you can specify the version of the .NET SDK to use.
-dotnet_register_toolchains("dotnet", "8.0.100")
-
-load("@rules_dotnet//dotnet:paket.rules_dotnet_nuget_packages.bzl", "rules_dotnet_nuget_packages")
-
-rules_dotnet_nuget_packages()
-\`\`\`
 EOF

BUILD.bazel

@@ -1,5 +1,4 @@
 load("@bazel_gazelle//:def.bzl", "gazelle", "gazelle_binary")
-load("@bazel_skylib//:bzl_library.bzl", "bzl_library")
 
 package(default_visibility = ["//visibility:public"])
 
@@ -15,12 +14,3 @@ gazelle(
     name = "gazelle",
     gazelle = "gazelle_bin",
 )
-
-bzl_library(
-    name = "internal_deps",
-    srcs = ["internal_deps.bzl"],
-    deps = [
-        "@bazel_tools//tools/build_defs/repo:http.bzl",
-        "@bazel_tools//tools/build_defs/repo:utils.bzl",
-    ],
-)

MODULE.bazel

@@ -8,7 +8,7 @@ module(
 )
 
 dotnet = use_extension("@rules_dotnet//dotnet:extensions.bzl", "dotnet")
-dotnet.toolchain(dotnet_version = "8.0.100")
+dotnet.toolchain(dotnet_version = "8.0.200")
 use_repo(dotnet, "dotnet_toolchains")
 
 register_toolchains("@dotnet_toolchains//:all")
@@ -19,11 +19,20 @@ use_repo(paket2bazel_dependencies_extension, "paket.paket2bazel_dependencies")
 rules_dotnet_nuget_packages_extension = use_extension("//dotnet:paket.rules_dotnet_nuget_packages_extension.bzl", "rules_dotnet_nuget_packages_extension")
 use_repo(rules_dotnet_nuget_packages_extension, "paket.rules_dotnet_nuget_packages")
 
+targeting_packs_extension = use_extension("//dotnet/private/sdk/targeting_packs:dotnet.targeting_packs_extension.bzl", "targeting_packs_extension")
+use_repo(targeting_packs_extension, "dotnet.targeting_packs")
+
+runtime_packs_extension = use_extension("//dotnet/private/sdk/runtime_packs:dotnet.runtime_packs_extension.bzl", "runtime_packs_extension")
+use_repo(runtime_packs_extension, "dotnet.runtime_packs")
+
+apphost_packs_extension = use_extension("//dotnet/private/sdk/apphost_packs:dotnet.apphost_packs_extension.bzl", "apphost_packs_extension")
+use_repo(apphost_packs_extension, "dotnet.apphost_packs")
+
 bazel_dep(name = "bazel_skylib", version = "1.4.2")
-bazel_dep(name = "platforms", version = "0.0.7")
+bazel_dep(name = "platforms", version = "0.0.9")
 
 # Dev dependencies
-bazel_dep(name = "rules_pkg", version = "0.9.1", dev_dependency = True)
+bazel_dep(name = "rules_pkg", version = "0.10.1", dev_dependency = True)
 bazel_dep(name = "gazelle", version = "0.33.0", dev_dependency = True, repo_name = "bazel_gazelle")
 bazel_dep(name = "bazel_skylib_gazelle_plugin", version = "1.4.2", dev_dependency = True)
 bazel_dep(name = "rules_cc", version = "0.0.9", dev_dependency = True)

WORKSPACE

@@ -1,71 +1 @@
 workspace(name = "rules_dotnet")
-
-load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
-load(":internal_deps.bzl", "rules_dotnet_internal_deps")
-
-# Fetch deps needed only locally for development
-rules_dotnet_internal_deps()
-
-# Fetch dependencies needed by end-users
-load(
-    "//dotnet:repositories.bzl",
-    "dotnet_register_toolchains",
-    "rules_dotnet_dependencies",
-)
-
-rules_dotnet_dependencies()
-
-dotnet_register_toolchains("dotnet", "8.0.100")
-
-# Fetch NuGet packages needed by end-users
-load("//dotnet:paket.rules_dotnet_nuget_packages.bzl", "rules_dotnet_nuget_packages")
-
-rules_dotnet_nuget_packages()
-
-load("//dotnet:paket.paket2bazel_dependencies.bzl", "paket2bazel_dependencies")
-
-paket2bazel_dependencies()
-
-# Fetch NuGet packages needed for our tests
-load("//dotnet:paket.rules_dotnet_dev_nuget_packages.bzl", "rules_dotnet_dev_nuget_packages")
-
-rules_dotnet_dev_nuget_packages()
-
-# For running our own unit tests
-load("@bazel_skylib//:workspace.bzl", "bazel_skylib_workspace")
-
-bazel_skylib_workspace()
-
-load("@rules_pkg//:deps.bzl", "rules_pkg_dependencies")
-
-rules_pkg_dependencies()
-
-load("@bazel_gazelle//:deps.bzl", "gazelle_dependencies")
-
-############################################
-# Gazelle, for generating bzl_library targets
-load("@io_bazel_rules_go//go:deps.bzl", "go_register_toolchains", "go_rules_dependencies")
-
-go_rules_dependencies()
-
-go_register_toolchains(version = "1.20.5")
-
-gazelle_dependencies()
-
-# Used for Bazel CI
-http_archive(
-    name = "bazelci_rules",
-    sha256 = "eca21884e6f66a88c358e580fd67a6b148d30ab57b1680f62a96c00f9bc6a07e",
-    strip_prefix = "bazelci_rules-1.0.0",
-    url = "https://github.com/bazelbuild/continuous-integration/releases/download/rules-1.0.0/bazelci_rules-1.0.0.tar.gz",
-)
-
-load("@bazelci_rules//:rbe_repo.bzl", "rbe_preconfig")
-
-# Creates a default toolchain config for RBE.
-# Use this as is if you are using the rbe_ubuntu16_04 container,
-# otherwise refer to RBE docs.
-rbe_preconfig(
-    name = "buildkite_config",
-    toolchain = "ubuntu1804-bazel-java11",
-)