Skip to content

Commit d771b76

Browse files
committed
fix dll include again
1 parent 96c5929 commit d771b76

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

python/private/local_runtime_repo_setup.bzl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -156,9 +156,9 @@ def define_local_runtime_toolchain_impl(
156156
venv_bin_files = select({
157157
"@platforms//os:windows": native.glob(
158158
include = [
159-
"*.dll",
159+
"lib/*.dll",
160160
# The pdb files just provide debugging information
161-
"*.pdb",
161+
"lib/*.pdb",
162162
],
163163
# This must be true because glob empty-ness is checked
164164
# during loading phase, before select() filters it out.

python/private/py_executable.bzl

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -728,6 +728,8 @@ def _create_venv_windows(ctx, *, venv_root, runtime, interpreter_actual_path):
728728
interpreter_runfiles.add(interpreter)
729729
ctx.actions.symlink(output = interpreter, target_path = runtime.interpreter_path)
730730

731+
# NOTE: The .dll files must exist, however, they may not be known at build time
732+
# if the interpreter is resolved at runtime.
731733
for f in runtime.venv_bin_files:
732734
venv_path = "{}/{}".format(bin_dir, f.basename)
733735
venv_file = ctx.actions.declare_file(venv_path)

0 commit comments

Comments
 (0)