refactor: Migrate resource-strip-prefix and library-suite build failures to Bazel

Move test_expect_failure/mismatching_resource_strip_prefix and
test_expect_failure/scala_library_suite into test/resource_strip_prefix and
test/scala_library_suite, driven by expect_build_failure_test instead of the
scala_library_jar_without_srcs_must_fail_on_mismatching_resource_strip_prefix
(test/shell/test_scala_library_jar.sh) and test_scala_library_suite
(test/shell/test_scala_library.sh) cases.

scala_library_suite now forwards `tags` to the aggregate suite target as well
(children already receive them via **kwargs), so `tags = ["manual"]` keeps the
whole suite -- which depends on a deliberately invalid child -- out of wildcard
builds.

Author: PawelLipski

scala/private/rules/scala_library.bzl

@@ -145,6 +145,10 @@ def scala_library_suite(
         visibility = visibility,
         exports = exports + ts,
         deps = ts,
+        # Forward tags to the aggregate target too (children already get them via
+        # **kwargs), so e.g. `tags = ["manual"]` can keep the whole suite -- which
+        # depends on every child -- out of wildcard builds.
+        tags = kwargs.get("tags", []),
     )
 
 ##

test/resource_strip_prefix/BUILD

@@ -0,0 +1,17 @@
+load("//scala:scala.bzl", "scala_library")
+load("//test/expect_build_failure:expect_build_failure.bzl", "expect_build_failure_test")
+
+# A resource_strip_prefix that does not match the resource's path must be
+# rejected. Tagged "manual" so wildcard builds skip it; the sh_test drives a
+# nested `bazel build` and asserts the failure.
+scala_library(
+    name = "noSrcsJarWithWrongStripPrefix",
+    resource_strip_prefix = "wrong_prefix",
+    resources = ["resource.txt"],
+    tags = ["manual"],
+)
+
+expect_build_failure_test(
+    name = "mismatching_resource_strip_prefix_build_test",
+    target = ":noSrcsJarWithWrongStripPrefix",
+)

…ching_resource_strip_prefix/resource.txt test/resource_strip_prefix/resource.txttest_expect_failure/mismatching_resource_strip_prefix/resource.txt renamed to test/resource_strip_prefix/resource.txt test_expect_failure/mismatching_resource_strip_prefix/resource.txt renamed to test/resource_strip_prefix/resource.txt

@@ -0,0 +1,16 @@
+load("//scala:scala.bzl", "scala_library_suite")
+load("//test/expect_build_failure:expect_build_failure.bzl", "expect_build_failure_test")
+
+# A scala_library_suite whose children depend on one another must be rejected.
+# Tagged "manual" so wildcard builds skip it; the sh_test drives a nested
+# `bazel build` and asserts the failure.
+scala_library_suite(
+    name = "library_suite_dep_on_children",
+    srcs = glob(["Data*.scala"]),
+    tags = ["manual"],
+)
+
+expect_build_failure_test(
+    name = "scala_library_suite_build_test",
+    target = ":library_suite_dep_on_children",
+)

test/scala_library_suite/BUILD

@@ -49,10 +49,6 @@ test_scala_library_expect_no_recompilation_of_target_on_internal_change_of_depen
   test_scala_library_expect_no_recompilation_on_internal_change $1 $2 ":user" "'user'"
 }
 
-test_scala_library_suite() {
-  action_should_fail build test_expect_failure/scala_library_suite:library_suite_dep_on_children
-}
-
 test_scala_library_expect_failure_on_missing_direct_internal_deps() {
   dependenecy_target='//test_expect_failure/missing_direct_deps/internal_deps:transitive_dependency'
   test_target='test_expect_failure/missing_direct_deps/internal_deps:transitive_dependency_user'
@@ -179,7 +175,6 @@ test_scala_library_expect_better_failure_message_on_missing_transitive_dependenc
   test_expect_failure_or_warning_on_missing_direct_deps_with_expected_message "${expected_message}" $test_target "--extra_toolchains=//test/toolchains:high_level_transitive_deps_strict_deps_error"
 }
 
-$runner test_scala_library_suite
 $runner test_scala_library_expect_failure_on_missing_direct_internal_deps
 $runner test_scala_library_expect_failure_on_missing_direct_external_deps_jar
 $runner test_scala_library_expect_failure_on_missing_direct_external_deps_file_group

…_failure/scala_library_suite/DataA.scala test/scala_library_suite/DataA.scalatest_expect_failure/scala_library_suite/DataA.scala renamed to test/scala_library_suite/DataA.scala test_expect_failure/scala_library_suite/DataA.scala renamed to test/scala_library_suite/DataA.scala

@@ -21,10 +21,5 @@ scala_library_jar_without_srcs_must_include_filegroup_resources(){
   test_resources "noSrcsWithFilegroupResources"
 }
 
-scala_library_jar_without_srcs_must_fail_on_mismatching_resource_strip_prefix() {
-  action_should_fail build test_expect_failure/mismatching_resource_strip_prefix:noSrcsJarWithWrongStripPrefix
-}
-
-$runner scala_library_jar_without_srcs_must_fail_on_mismatching_resource_strip_prefix
 $runner scala_library_jar_without_srcs_must_include_direct_file_resources
 $runner scala_library_jar_without_srcs_must_include_filegroup_resources