refactor: Migrate transitive strict-deps build-failure tests to Bazel

Move the transitive/{scala_to_scala,java_to_scala,scala_to_java} fixtures from
test_expect_failure into test/transitive, driven by expect_build_failure_test
instead of the test_transitive_deps case in test/shell/test_misc.sh. Each `:d`
target uses a type reachable only transitively, so strict deps must reject the
build; the java_to_scala case additionally asserts the "indirect dependency"
error message.

Author: PawelLipski

test/shell/test_misc.sh

@@ -23,32 +23,6 @@ test_disappearing_class() {
   set -e
 }
 
-test_transitive_deps() {
-  set +e
-
-  bazel build test_expect_failure/transitive/scala_to_scala:d
-  if [ $? -eq 0 ]; then
-    echo "'bazel build test_expect_failure/transitive/scala_to_scala:d' should have failed."
-    exit 1
-  fi
-
-  expected_message="error: [strict] Using type example.A from an indirect dependency"
-  output=$(bazel build test_expect_failure/transitive/java_to_scala:d 2>&1)
-  if [ $? -eq 0 ] || [[ "$output" != *"$expected_message"* ]]; then
-    echo "'bazel build test_expect_failure/transitive/java_to_scala:d' should have failed with message '$expected_message'."
-    exit 1
-  fi
-
-  bazel build test_expect_failure/transitive/scala_to_java:d
-  if [ $? -eq 0 ]; then
-    echo "'bazel build test_transitive_deps/scala_to_java:d' should have failed."
-    exit 1
-  fi
-
-  set -e
-  exit 0
-}
-
 test_repl() {
   local query_results=$(bazel query 'kind(scala_repl, //test/...)')
   #local query_results="${query_results//$'\r'}" #make sure \r is removed so bash can parse args correctly on windows
@@ -118,7 +92,6 @@ xmllint_test() {
 }
 
 $runner test_disappearing_class
-$runner test_transitive_deps
 $runner test_repl
 $runner test_benchmark_jmh
 $runner scala_test_test_filters

…failure/transitive/java_to_scala/A.scala test/transitive/java_to_scala/A.scalatest_expect_failure/transitive/java_to_scala/A.scala renamed to test/transitive/java_to_scala/A.scala test_expect_failure/transitive/java_to_scala/A.scala renamed to test/transitive/java_to_scala/A.scala

@@ -0,0 +1,30 @@
+load("@rules_java//java:defs.bzl", "java_library")
+load("//scala:scala.bzl", "scala_library")
+load("//test/expect_build_failure:expect_build_failure.bzl", "expect_build_failure_test")
+
+scala_library(
+    name = "a",
+    srcs = ["A.scala"],
+)
+
+java_library(
+    name = "c",
+    srcs = ["C.java"],
+    deps = [":a"],
+)
+
+# `d` uses a Scala type reachable only transitively (through `c`); strict deps
+# must reject building it with the "indirect dependency" error. Tagged "manual"
+# so wildcard builds skip it; the sh_test drives a nested `bazel build`.
+java_library(
+    name = "d",
+    srcs = ["D.java"],
+    tags = ["manual"],
+    deps = [":c"],
+)
+
+expect_build_failure_test(
+    name = "transitive_java_to_scala_build_test",
+    expect = ["expected_indirect_dependency.txt"],
+    target = ":d",
+)

test/transitive/java_to_scala/BUILD

@@ -0,0 +1 @@
+error: [strict] Using type example.A from an indirect dependency

…_failure/transitive/java_to_scala/C.java test/transitive/java_to_scala/C.javatest_expect_failure/transitive/java_to_scala/C.java renamed to test/transitive/java_to_scala/C.java test_expect_failure/transitive/java_to_scala/C.java renamed to test/transitive/java_to_scala/C.java

@@ -0,0 +1,33 @@
+load("@rules_java//java:defs.bzl", "java_library")
+load("//scala:scala.bzl", "scala_library")
+load("//test/expect_build_failure:expect_build_failure.bzl", "expect_build_failure_test")
+
+java_library(
+    name = "a",
+    srcs = ["A.java"],
+)
+
+scala_library(
+    name = "b",
+    exports = [":a"],
+)
+
+scala_library(
+    name = "c",
+    deps = [":b"],
+)
+
+# `d` uses a Java type reachable only transitively (through `c` -> `b` ->
+# exported `a`); strict deps must reject building it. Tagged "manual" so wildcard
+# builds skip it; the sh_test drives a nested `bazel build` and asserts the failure.
+scala_library(
+    name = "d",
+    srcs = ["D.scala"],
+    tags = ["manual"],
+    deps = [":c"],
+)
+
+expect_build_failure_test(
+    name = "transitive_scala_to_java_build_test",
+    target = ":d",
+)