chore: Use absolute paths for buildifier

This has multiple positive effects:
- buildifier can be used on any Starlark file even if not bazel workspace is present
- buildifier can be used on standalone files outside your current workspace
- buildifier will work robustly for multi-workspace setups

Closes #620

Author: cbandera

src/buildifier/buildifier_diagnostics_manager.ts

@@ -13,9 +13,7 @@
 // limitations under the License.
 
 import * as vscode from "vscode";
-import * as path from "path";
 import { buildifierLint } from "./buildifier";
-import { BazelWorkspaceInfo } from "../bazel";
 import { ILogger } from "../extension/logger";
 
 /**
@@ -86,23 +84,11 @@ export class BuildifierDiagnosticsManager implements vscode.Disposable {
     if (document.languageId === "starlark") {
       this.logger.logDebug(`Updating diagnostics for ${document.uri.fsPath}`);
 
-      const workspaceInfo = BazelWorkspaceInfo.fromDocument(document);
-      if (!workspaceInfo) {
-        this.logger.logDebug(
-          "No workspace info found for document",
-          false,
-          document.uri.fsPath,
-        );
-        return;
-      }
-      const workspaceRelativePath = path.relative(
-        workspaceInfo.bazelWorkspacePath,
-        document.uri.fsPath,
-      );
+      const absolutePath = document.uri.fsPath;
 
       const warnings = await buildifierLint(
         document.getText(),
-        workspaceRelativePath,
+        absolutePath,
         "warn",
       );
       this.logger.logDebug(`Found ${warnings.length} warnings`);

src/buildifier/buildifier_format_provider.ts

@@ -13,9 +13,7 @@
 // limitations under the License.
 
 import * as vscode from "vscode";
-import * as path from "path";
 import { buildifierFormat } from "./buildifier";
-import { BazelWorkspaceInfo } from "../bazel";
 import { getBuildifierFixOnFormat } from "../extension/configuration";
 import { ILogger } from "../extension/logger";
 
@@ -38,23 +36,11 @@ export class BuildifierFormatProvider
     this.logger.logDebug(`Formatting document: ${document.uri.fsPath}`);
 
     const fileContent = document.getText();
-    const workspaceInfo = BazelWorkspaceInfo.fromDocument(document);
-    if (!workspaceInfo) {
-      this.logger.logDebug(
-        "No workspace info found for document during formatting",
-        false,
-        document.uri.fsPath,
-      );
-      return [];
-    }
-    const workspaceRelativePath = path.relative(
-      workspaceInfo.bazelWorkspacePath,
-      document.uri.fsPath,
-    );
+    const absolutePath = document.uri.fsPath;
     try {
       const formattedContent = await buildifierFormat(
         fileContent,
-        workspaceRelativePath,
+        absolutePath,
         getBuildifierFixOnFormat(),
       );
       if (formattedContent === fileContent) {