Skip to content
This repository has been archived by the owner on Mar 8, 2020. It is now read-only.

unmapped node in semantic mode Scalar_String: [attributes comments] #35

Open
bzz opened this issue Mar 21, 2019 · 2 comments
Open

unmapped node in semantic mode Scalar_String: [attributes comments] #35

bzz opened this issue Mar 21, 2019 · 2 comments
Labels
Milestone

Comments

@bzz
Copy link
Contributor

bzz commented Mar 21, 2019

Discovered as part of the bblfsh/bblfshd#268 (comment)

Driver fails to parse e.g this php file with check: unused field(s) on node Scalar_String: [attributes comments].

Normalization mapping for semantic mode needs to be updated.

@bzz bzz added the bug label Mar 21, 2019
@bzz bzz added this to the v2.7.2 milestone Mar 21, 2019
@dennwc
Copy link
Member

dennwc commented Mar 26, 2019

Looks like the wrong file is attached - cannot reproduce it, and the file does not contain any Scalar_String nodes.

@bzz
Copy link
Contributor Author

bzz commented Apr 5, 2019

@dennwc sorry for confusion! You can find 32 examples of such cases with

grep "language=php$" bblfshd.log | \
    grep -oP "rpc error: code = \K(.*)" | \
    grep "unused field(s) on node Scalar_String" | \
    grep -oP "filename=\"\K([^\"]*)"

in this log file (from the linked issue).

In details below this is a full list, for your convenience.

What I did above was just a search for one of the files from that list on a github and attached link in here. Most probably it may need to be repeated couple of times befor finding a right one, as logs do not have the names of the repositories.

vendor/psy/psysh/src/Psy/Command/ClearCommand.php
vendor/psy/psysh/src/Psy/Command/ExitCommand.php
vendor/symfony/process/Tests/PhpProcessTest.php
vendor/psy/psysh/test/Psy/Test/Formatter/CodeFormatterTest.php
vendor/symfony/var-dumper/Tests/Caster/PdoCasterTest.php
vendor/psy/psysh/src/Psy/Command/ThrowUpCommand.php
vendor/psy/psysh/src/Psy/Command/BufferCommand.php
vendor/symfony/console/Command/HelpCommand.php
vendor/nikic/php-parser/test/PhpParser/NodeDumperTest.php
vendor/symfony/console/Command/ListCommand.php
vendor/squizlabs/php_codesniffer/src/Standards/PSR2/Tests/Methods/FunctionCallSignatureUnitTest.inc
vendor/psy/psysh/src/Psy/Util/Str.php
vendor/psy/psysh/src/Psy/Command/DumpCommand.php
vendor/symfony/config/Tests/Definition/Dumper/XmlReferenceDumperTest.php
vendor/nikic/php-parser/test/PhpParser/BuilderFactoryTest.php
vendor/symfony/config/Tests/Definition/Dumper/YamlReferenceDumperTest.php
vendor/psy/psysh/src/Psy/Command/WtfCommand.php
vendor/psy/psysh/src/Psy/Command/SudoCommand.php
vendor/psy/psysh/src/Psy/Command/WhereamiCommand.php
vendor/nikic/php-parser/test/PhpParser/Builder/ClassTest.php
vendor/psy/psysh/src/Psy/Compiler.php
vendor/psy/psysh/src/Psy/Command/ParseCommand.php
vendor/psy/psysh/src/Psy/Command/TraceCommand.php
vendor/symfony/config/Tests/Resource/ReflectionClassResourceTest.php
vendor/nikic/php-parser/test/PhpParser/ParserTest.php
vendor/psy/psysh/src/Psy/Command/HistoryCommand.php
vendor/psy/psysh/src/Psy/Command/ListCommand.php
vendor/cakephp/cakephp/src/Core/StaticConfigTrait.php
vendor/cakephp/plugin-installer/src/Installer/PluginInstaller.php
vendor/symfony/var-dumper/Dumper/HtmlDumper.php
lib/tests/output_external_test.php
lib/tests/output_external_test.php

Hope this helps!

@bzz bzz removed their assignment Apr 5, 2019
@bzz bzz removed the invalid label Apr 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants