Skip to content

[WARNING] Compiler Warnings When Targetting .Net 8+ (Please Merge #611) #617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
uniblab opened this issue May 5, 2025 · 0 comments
Open

Comments

@uniblab
Copy link
Contributor

uniblab commented May 5, 2025

** Issue **
New compiler warnings are generated when compiling under .Net 8+. This is because the many Exception-derived classes in the BouncyCastle.Cryptography library implement or override code which has been marked Obsolete in the .Net 8+ runtimes. As a best practice, compiler warnings should be resolved instead of ignored.

** Solution **
Mark each such method with the Obsolete attribute and then Molly-guard the attribute inside NET8_0_OR_GREATER. This way it does not alter current code but ensures proper .Net 8+ compilation. This solution has already been implemented and made available as Pull Request #611 .

** Requested Action **
Please review and merge PR #611 . This PR has passed all tests on all configurations.

** Impact **
There is no impact to current compilation settings. It resolves numerous compiler warnings when compiling under .Net 8+, which is expected to happen in the near future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant