Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misalignment (and incorrect colour) of several element in Navigation View #1181

Open
Hopy-Jaden opened this issue Feb 6, 2025 · 0 comments
Labels
bug Something isn't working w: NavigationView Related to the NavigationView widget

Comments

@Hopy-Jaden
Copy link

Hopy-Jaden commented Feb 6, 2025

Context
I’ve seen that the navigation view rework is set to be released later this year on Discord (very excited about it). I am not sure if this is a bug or enhancement, but the following behaviour mentioned in this issue should not be intended according to Microsoft guidelines. Also, I updated issue #669 to provide some insight to easier customising the navigation view in the future. XD

Describe the bug and its corresponding expected behaviour

  1. InfoBadge in PaneItem() is misaligned to the top centre, it looks weird. Please align it to the centre
Misaligned top centre of the badge Expected alignment centred at the badge (in WinUI3 Gallery)
Image Image
  1. Indicator of PaneItemExpander() is misaligned outside of the box. Indicator should behave the same as PaneItem(), i.e. it should be inside the box
Misaligned outside the box (PaneItemExpander()) Expected alignment Inside the box (PaneItemExpander() in WinUI3 Gallery) Correct alignment Inside the box (PaneItem())
Image Image Image
  1. PaneItemHeader() is misaligned and stick to the Pane Item below. Please add back the same padding as PaneItem().
Lack of padding and stick to the pane item below (PaneItemHeader()) Expected Consistent padding (PaneItemHeader() in WinUI3 Gallery) Consistant padding (PaneItem())
Image Image Image
  1. The colour of the Header isn't white or black but (estimated 5c5c5c in light mode) and (estimated cccccc in dark mode)
Incorrect black colour in light mode (PaneItemHeader()) Expected 5c5c5c colour in light mode (PaneItemHeader() in WinUI3 Gallery) Incorrect white colour in dark mode (PaneItemHeader()) Expected cccccc colour in dark mode (PaneItemHeader() in WinUI3 Gallery)
Image Image Image Image
  1. The indicator is not in correctly sized and rounded. Please follow the guideline and make the indicator short and consistent, with two edge being rounded.
Lack of roundness and overlengthed indicator (Current Library Implementation) Expected look/length of the indicator (Current Library Implementation) Correct look of indicator (WinUI 3 Gallery)
Image Image Image

P.S. If you look carefully, the current implementation of indicator look way longer then should be, as mentioned in #664. Therefore, even if it may be window 11 styled, the incorrect size make the bar not seamlessly blend into windows 11 like native winUI 3 apps.

@bdlukaa bdlukaa added bug Something isn't working w: NavigationView Related to the NavigationView widget labels Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working w: NavigationView Related to the NavigationView widget
Projects
None yet
Development

No branches or pull requests

2 participants