Skip to content

Commit 93f2ed3

Browse files
authored
[Bug] Fix compilation error when defining QUICK_TAP_TERM_PER_KEY (#19893)
1 parent 24a86d5 commit 93f2ed3

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

quantum/action_tapping.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ void action_tapping_process(keyrecord_t record) {
122122
* readable. The conditional definition of tapping_keycode and all the
123123
* conditional uses of it are hidden inside macros named TAP_...
124124
*/
125-
# if (defined(AUTO_SHIFT_ENABLE) && defined(RETRO_SHIFT)) || defined(PERMISSIVE_HOLD_PER_KEY) || defined(QUICK_TAP_TERM_PER_KEY) || defined(HOLD_ON_OTHER_KEY_PRESS_PER_KEY)
125+
# if (defined(AUTO_SHIFT_ENABLE) && defined(RETRO_SHIFT)) || defined(PERMISSIVE_HOLD_PER_KEY) || defined(HOLD_ON_OTHER_KEY_PRESS_PER_KEY)
126126
# define TAP_DEFINE_KEYCODE uint16_t tapping_keycode = get_record_keycode(&tapping_key, false)
127127
# else
128128
# define TAP_DEFINE_KEYCODE

tests/tap_hold_configurations/quick_tap/config.h

+4
Original file line numberDiff line numberDiff line change
@@ -19,3 +19,7 @@
1919
#include "test_common.h"
2020

2121
#define QUICK_TAP_TERM 100
22+
// Although a seemingly superfluous addition since the default per-key function behaves
23+
// no differently from defining a single global QUICK_TAP_TERM, this has been useful
24+
// to catch compilation errors and prevent regressions in the future; see PR #19893.
25+
#define QUICK_TAP_TERM_PER_KEY

0 commit comments

Comments
 (0)