Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add brightness slider for transfer activity #1612

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

michaelschattgen
Copy link
Member

image

Fixes #1610

@michaelschattgen michaelschattgen marked this pull request as draft February 24, 2025 21:49
@michaelschattgen michaelschattgen force-pushed the feature/brightness-slider-transfer branch from 3ab39e5 to 136de4a Compare February 25, 2025 21:53
@michaelschattgen michaelschattgen marked this pull request as ready for review February 28, 2025 11:00
Copy link
Member

@alexbakker alexbakker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, much better than my blind-the-user-by-default approach. Just two nitpicks.

@@ -47,6 +48,8 @@ public class TransferEntriesActivity extends AegisActivity {
private Button _previousButton;
private Button _copyButton;
private int _currentEntryCount = 1;
private float _deviceBrightness;
private boolean isMaxBrightnessSet = false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is missing a _ prefix.

getWindow().setAttributes(attrs);
getSystemBrightness();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this getSystemBrightness() call can be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature proposal: Limit QR code brightness
2 participants