Tech housekeeping

[dtinth]

Still no planned active maintenance, but plan to explore:

• Check if the project is still buildable.
• Investigate/fix timesync.
• Investigate/fix BGA not loading.
• Investigate/fix number input handling.
• Investigate/fix gamepad handling.
• Other small issues.

[dtinth]

@dtinth-claw[bot] Is the bridge working?

[dtinth-claw]

Yes — the bridge is working. 👋 I received your comment through the Grist poller (filtered to this repo, this issue, and your user id), and this reply was posted via the bridge's send command. Ready for the housekeeping work whenever you are.

[dtinth]

Can you try building the project and see if it is still working? It hasn't been updated for ~4 years!

[dtinth-claw]

@dtinth On it — I'll try a clean install and build and report back what works and what breaks.

[dtinth-claw]

@dtinth Good news — it still builds. 🎉

What I did

• Installed the pinned toolchain: Node 16.18.0 (.nvmrc/volta.json), Rush 5.82.1, pnpm 6.7.1.
• rush install → OK (~52s).
• node build-scripts build → the app (bemuse) and all 8 packages compile cleanly, producing a 114 MB dist/ (index.html, service worker, skins, docs). App output alone is ~101 MB.

One snag, easy to fix
The build script currently exits non-zero, but not because anything is actually broken — it's a stale-data warning being treated as an error:

• caniuse-lite is ~4 years old (1.0.30001442), so browserslist prints an "outdated" warning.
• The Rush build command doesn't set allowWarningsInSuccessfulBuild (unlike lint/test), so that warning fails the run and aborts before the final dist assembly step.
• Running the assembly step manually afterward completes fine — hence the working 114 MB bundle above.

Suggested fixes (either works):

1. npx update-browserslist-db@latest to refresh caniuse-lite, or
2. add allowWarningsInSuccessfulBuild: true to the build command in common/config/rush/command-line.json.

Want me to open a PR with the fix? If so, which option do you prefer?

[dtinth]

Later, for now please try to run our unit tests and end-to-end tests, both for the main application and for all the sub-projects.

[dtinth-claw]

@dtinth Got it — running unit tests for the main app and all sub-projects now, then I'll attempt the Playwright e2e suite. Will report results as they come in.

[dtinth-claw]

@dtinth Tests are green across the board. ✅

Sub-project unit tests — rush test --to-except bemuse → pass

• bms, bmson, bemuse-notechart, bemuse-indexer, bemuse-types, monetizer, eslint-config-bemuse all OK.
• Two non-fatal warnings: bms clones the bmspec submodule and logs WARNING! ./bmspec/features/.../*.feature does not exist (some spec paths seem to have moved), and monetizer's output is flagged as a warning but its Jest suite passes (6/6). Neither fails the run.

Main app unit tests — rushx test in bemuse/ (Karma + headless Chrome) → 310 passed, 1 skipped

• A couple of transient Unable to download .../hello.txt errors appeared mid-run but auto-retried and the suite finished green.

End-to-end tests — Playwright (Chromium) against the freshly built dist/ → 15 passed, 1 skipped (CI config: workers: 1)

• Covers gameplay smoke test (scoring), online ranking/auth, options, search, project site, service worker, unsupported-browser.
• One thing worth noting: when I first ran the suite fully parallel (Playwright's non-CI default), online-ranking › Keeps highest score failed because the fake-scoreboard mock shares state across the tests that log in as tester. Running single-worker (as CI does) it passes reliably. So it's a test-isolation quirk, not a product bug — but the suite currently only works parallel-safe under workers: 1.

Net: the ~4-year-dormant project builds and all test suites pass. The only real housekeeping items surfaced so far are the caniuse-lite build warning-as-error and this e2e parallel-isolation quirk. Want me to open PRs for either?

[dtinth]

Yes, please open a single PR for this work. And when you open a PR, please check the GitHub Actions runs. Please shepherd it to green.

[dtinth-claw]

Understood — opening a single PR now, then I'll watch the GitHub Actions runs and iterate until everything's green.

[dtinth-claw]

Opened the PR and started the CI runs:

• Fix CI build failing on benign warnings and flaky parallel e2e #846

First runs surfaced something bigger than the two fixes: the pipeline was failing because GitHub has disabled the old Action versions the repo pins — actions/cache@v2, actions/upload-artifact@v3/download-artifact@v3 are auto-failed now, and checkout@v2/v3 + setup-node@v2 run on deprecated Node runtimes. This affected every job (and would break master too), independent of my changes.

I've added the necessary version bumps to the same PR (cache→v4, artifacts→v4, checkout/setup-node→v4, github-script→v7, codecov→v4) and pushed. A fresh run is executing the full build + unit + e2e suites now — I'll report once it settles and keep iterating if anything's still red.

[dtinth-claw]

@dtinth Done — CI is fully green and the PR is mergeable:

• Fix CI build failing on benign warnings and flaky parallel e2e #846

Every job passes: build, test, test_packages, typecheck, tidy, e2e, changelog, and SonarCloud (deploy correctly skips on PRs).

It took four fixes to get there — the two I originally found, plus two CI-rot issues that were failing the whole pipeline independent of my changes:

1. Build — Rush treated the stale caniuse-lite Browserslist warning as a failure; now allowed on build (matching lint/test).
2. E2E flake — the shared-account online-ranking tests now run serially.
3. Deprecated Actions — GitHub had disabled cache@v2, upload/download-artifact@v3, setup-node@v2, etc.; bumped them all to current major versions.
4. E2E on Ubuntu 24.04 — Playwright 1.29's --with-deps breaks on 24.04's renamed apt packages; pinned the e2e job to ubuntu-22.04.

One thing worth flagging for later (not in this PR): the Node 16 / Rush 5.82 / pnpm 6.7 / Playwright 1.29 stack is what forced the ubuntu-22.04 pin and the Node-runtime deprecation warnings. A follow-up to modernize the toolchain would let e2e return to ubuntu-latest. Happy to take that on if you'd like.

The PR is ready for your review whenever you have a moment.