Merge remote-tracking branch 'benma/go120'

Author: benma

.github/workflows/ci.yml

@@ -21,7 +21,7 @@ env:
   # https://docs.github.com/en/packages/guides/pushing-and-pulling-docker-images
   #
   # Keep this in sync with default in scripts/travis-ci.sh.
-  CI_IMAGE: ghcr.io/digitalbitbox/bitbox-wallet-app-ci:16
+  CI_IMAGE: ghcr.io/digitalbitbox/bitbox-wallet-app-ci:17
   TRAVIS_BUILD_DIR: ${{github.workspace}}
 
 jobs:
@@ -103,7 +103,7 @@ jobs:
       - name: Install Go
         uses: actions/setup-go@v2
         with:
-          go-version: 1.19.x
+          go-version: 1.20.x
       - name: Build macOS app
         run: >
           ./scripts/travis-ci.sh qt-osx;

.golangci.yml

@@ -3,7 +3,7 @@
 
 # options for analysis running
 run:
-  go: 1.19
+  go: 1.20
 
   # default concurrency is a available CPU number
   concurrency: 4
@@ -134,6 +134,7 @@ linters:
     - nosnakecase
     - interfacebloat
     - revive
+    - musttag
   disable-all: false
 
 issues:

Makefile

@@ -21,7 +21,7 @@ catch:
 	@echo "Choose a make target."
 envinit:
 	# Keep golangci-lint version in sync with what's in .github/workflows/ci.yml.
-	curl -sfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh| sh -s -- -b $(GOPATH)/bin v1.50.1
+	curl -sfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh| sh -s -- -b $(GOPATH)/bin v1.51.1
 	go install github.com/vektra/mockery/v2@latest
 	go install github.com/matryer/moq@latest
 	go install golang.org/x/tools/cmd/goimports@latest
@@ -33,10 +33,10 @@ envinit:
 # Initializiation on MacOS
 #  - run make from $GOPATH/src/github.com/digitalbitbox/bitbox-wallet-app
 #  - additional dependencies: Qt 5.15 & Xcode command line tools
-#  - add to $PATH: /usr/local/opt/go@1.19/bin
+#  - add to $PATH: /usr/local/opt/go@1.20/bin
 osx-init:
 	/bin/bash -c "$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/master/install.sh)"
-	brew install go@1.19
+	brew install go@1.20
 	brew install qt@5
 	$(MAKE) envinit
 servewallet:

README.md

@@ -45,7 +45,7 @@ The below instructions assume a unix environment.
 
 To build the app or run the development workflow, the following dependencies need to be installed:
 
-- [Go](https://golang.org/doc/install) version 1.19
+- [Go](https://golang.org/doc/install) version 1.20
 - [Node.js](https://nodejs.org/) version 14.x
 - [NPM](https://docs.npmjs.com/about-npm-versions) version 7.x or newer
 - [Qt5](https://www.qt.io) version 5.15.2

appveyor.yml

@@ -11,7 +11,7 @@ environment:
 
 # https://www.appveyor.com/docs/windows-images-software/#golang
 # If you change this, also change the GOROOT variable above to point to the right installation folder.
-stack: go 1.19
+stack: go 1.19 # should be 1.20, but that is not available yet, see https://www.appveyor.com/docs/windows-images-software/#golang
 
 install:
   - ps: Install-Product node $env:nodejs_version

docs/BUILD.md

@@ -30,11 +30,11 @@ Build artifacts:
 
 ## MacOS
 
-Make sure you have `qt@5/bin`, `go@1.19/bin` and `go/bin` in your PATH, i.e. add to your `.zshrc`
+Make sure you have `qt@5/bin`, `go@1.20/bin` and `go/bin` in your PATH, i.e. add to your `.zshrc`
 
 ```bash
 export PATH="$PATH:/usr/local/opt/qt@5/bin"
-export PATH="$PATH:/usr/local/opt/go@1.19/bin"
+export PATH="$PATH:/usr/local/opt/go@1.20/bin"
 export PATH="$PATH:$HOME/go/bin"
 ```
 
@@ -65,7 +65,7 @@ $  xcrun altool --notarization-info NOTARIZATION_ID --username "APPLE_ID" --pass
 ## Windows
 
 The build requires `mingw-w64`, `bash` (e.g. `git-bash`), `make`, `Microsoft Visual Studio 2019`,
-`go 1.19`, `node@14`, `QT 5.15.2` with `qtwebengine`, `nsis` and possibly other tools.
+`go 1.20`, `node@14`, `QT 5.15.2` with `qtwebengine`, `nsis` and possibly other tools.
 
 Some of the tools are easy to install with `choco`:
 

scripts/docker_install.sh

@@ -46,7 +46,7 @@ npm install -g [email protected]
 npm install -g locize-cli
 
 mkdir -p /opt/go_dist
-curl https://dl.google.com/go/go1.19.3.linux-amd64.tar.gz | tar -xz -C /opt/go_dist
+curl https://dl.google.com/go/go1.20.1.linux-amd64.tar.gz | tar -xz -C /opt/go_dist
 
 # Needed for qt5. fuse is needed to run the linuxdeployqt appimage.
 apt-get install -y --no-install-recommends fuse

scripts/travis-ci.sh

@@ -14,7 +14,7 @@ if [ "$TRAVIS_OS_NAME" == "linux" ]; then
     # Which docker image to use to run the CI. Defaults to Docker Hub.
     # Overwrite with CI_IMAGE=docker/image/path environment variable.
     # Keep this in sync with .github/workflows/ci.yml.
-    : "${CI_IMAGE:=shiftcrypto/bitbox-wallet-app:16}"
+    : "${CI_IMAGE:=shiftcrypto/bitbox-wallet-app:17}"
     # Time image pull to compare in the future.
     time docker pull "$CI_IMAGE"