vr is extermely slow in Windows7

[pavlo-alkhimov]

Using profiler-start/profiler-report I figured out, that visual-regexp is very slow in Windows. In Linux this problem is not available.
GNU Emacs 25.3.1 (x86_64-w64-mingw32)
of 2017-09-12
visual-regexp 20161017.1713 from elpa

[benma]

vr starts a Python process for every keystroke, maybe Windows is less efficient with that? Maybe a long running Python process could be used instead.

Happy for anyone using Windows to analyze this and make a PR. Sorry I can't be of more help, I don't have access to any Windows machine.

[pavlo-alkhimov]

For those who are interested: http://python.readthedocs.io/en/v2.7.2/faq/windows.html#why-does-python-sometimes-take-so-long-to-start
It seems to be exactly my case as I use a company PC which checks if every executed program is permitted to run or not.

[net]

Only visual-regexp-steroids.el starts Python, correct?

Should these hooks be added when vr is entered and removed when it is ended?

visual-regexp.el/visual-regexp.el

Line 455 in b3096c2

(add-hook 'after-change-functions 'vr--after-change)

visual-regexp.el/visual-regexp.el

Line 463 in b3096c2

(add-hook 'minibuffer-setup-hook 'vr--minibuffer-setup)

[benma]

Yes, correct.

The hooks don't do anything when vr is not used actively, so it shouldn't be noticeable.

[benma]

Should these hooks be added when vr is entered and removed when it is ended?

Finally done in 3e3ed81