Skip to content
This repository has been archived by the owner on Apr 11, 2024. It is now read-only.

Benchmark borks if there are no script tags on the page. #142

Closed
stffrd opened this issue Jun 19, 2016 · 2 comments
Closed

Benchmark borks if there are no script tags on the page. #142

stffrd opened this issue Jun 19, 2016 · 2 comments

Comments

@stffrd
Copy link

stffrd commented Jun 19, 2016

You can consider this a wild edge case (and feel free to close as wont-fix), but I'm working on building a performance app for funsies, and I'm using a Vdom library in conjunction with benchmarkjs.

For the longest time I was mounting my app straight onto document.body (wherein I load my single script tag bundle), meaning the script element gets wiped on mounting, but stays in memory so it's able to be executed, but then the offending function is the attempt to inject a script tag next to the first found script tag

This, again, is an extremely unlikely use case, that being that for some reason you'd want to axe all of the script tags on a page, but I just wanted to have this documented somewhere in case someone runs into a similar problem and has a google-fit trying to search for a solution.

I might try my hands at a PR when I get some time. :)

@jdalton
Copy link
Member

jdalton commented Jun 19, 2016

I'd be up for a PR :)

@jdalton
Copy link
Member

jdalton commented Jun 21, 2016

Moved to #144.

@jdalton jdalton closed this as completed Jun 21, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

2 participants