File tree 2 files changed +9
-3
lines changed
packages/app-builder-lib/src
2 files changed +9
-3
lines changed Original file line number Diff line number Diff line change
1
+ ---
2
+ " app-builder-lib " : patch
3
+ ---
4
+
5
+ fix(mac): only skip notarization step when ` notarize ` is explicitly false
Original file line number Diff line number Diff line change @@ -498,12 +498,13 @@ export default class MacPackager extends PlatformPackager<MacConfiguration> {
498
498
499
499
private async notarizeIfProvided ( appPath : string , buildOptions : MacConfiguration ) {
500
500
const notarizeOptions = buildOptions . notarize
501
- if ( ! notarizeOptions ) {
502
- log . info ( { reason : "`notarize` options were not provided " } , "skipped macOS notarization" )
501
+ if ( notarizeOptions === false ) {
502
+ log . info ( { reason : "`notarize` options were set explicitly `false` " } , "skipped macOS notarization" )
503
503
return
504
504
}
505
505
const options = this . getNotarizeOptions ( appPath )
506
506
if ( ! options ) {
507
+ log . warn ( { reason : "`notarize` options were unable to be generated" } , "skipped macOS notarization" )
507
508
return
508
509
}
509
510
await notarize ( options )
@@ -561,7 +562,7 @@ export default class MacPackager extends PlatformPackager<MacConfiguration> {
561
562
}
562
563
return proj
563
564
}
564
- const { teamId } = options as NotarizeNotaryOptions
565
+ const teamId = ( options as NotarizeNotaryOptions ) ?. teamId
565
566
if ( ( teamId || options === true ) && ( legacyLogin || notaryToolLogin ) ) {
566
567
const proj : NotaryToolStartOptions = {
567
568
appPath,
You can’t perform that action at this time.
0 commit comments