Skip to content

Commit c4f5497

Browse files
authored
fix: update @electron/asar to 3.2.18 to resolve signing issue with framework symlinks (electron-userland#8762)
fixes: electron-userland#8655
1 parent 5c44725 commit c4f5497

File tree

4 files changed

+26
-7
lines changed

4 files changed

+26
-7
lines changed

.changeset/cuddly-colts-laugh.md

+5
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"app-builder-lib": patch
3+
---
4+
5+
fix: update @electron/asar to 3.2.18 to resolve signing issue with framework symlinks

packages/app-builder-lib/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@
4848
"dependencies": {
4949
"@develar/schema-utils": "~2.6.5",
5050
"@electron/fuses": "^1.8.0",
51-
"@electron/asar": "3.2.17",
51+
"@electron/asar": "3.2.18",
5252
"@electron/notarize": "2.5.0",
5353
"@electron/osx-sign": "1.3.1",
5454
"@electron/rebuild": "3.7.0",

pnpm-lock.yaml

+6-6
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

test/snapshots/globTest.js.snap

+14
Original file line numberDiff line numberDiff line change
@@ -9906,15 +9906,19 @@ exports[`symlinks everywhere w/ static framework 3`] = `
99069906
"files": {
99079907
"Headers": {
99089908
"link": "node_modules/hello-world/lib/Release/Hello.framework/Versions/Current/Headers",
9909+
"unpacked": true,
99099910
},
99109911
"Hello": {
99119912
"link": "node_modules/hello-world/lib/Release/Hello.framework/Versions/Current/Hello",
9913+
"unpacked": true,
99129914
},
99139915
"Info.plist": {
99149916
"link": "node_modules/hello-world/lib/Release/Hello.framework/Versions/Current/Info.plist",
9917+
"unpacked": true,
99159918
},
99169919
"Modules": {
99179920
"link": "node_modules/hello-world/lib/Release/Hello.framework/Versions/Current/Modules",
9921+
"unpacked": true,
99189922
},
99199923
"Versions": {
99209924
"files": {
@@ -9992,6 +9996,7 @@ exports[`symlinks everywhere w/ static framework 3`] = `
99929996
},
99939997
"Current": {
99949998
"link": "node_modules/hello-world/lib/Release/Hello.framework/Versions/A",
9999+
"unpacked": true,
999510000
},
999610001
},
999710002
"unpacked": true,
@@ -10049,6 +10054,11 @@ exports[`symlinks everywhere w/ static framework 4`] = `
1004910054
",
1005010055
"name": "app.asar.unpacked/node_modules/hello-world/package.json",
1005110056
},
10057+
"app.asar.unpacked/node_modules/hello-world/lib/Release/Hello.framework/Headers",
10058+
"app.asar.unpacked/node_modules/hello-world/lib/Release/Hello.framework/Hello",
10059+
"app.asar.unpacked/node_modules/hello-world/lib/Release/Hello.framework/Info.plist",
10060+
"app.asar.unpacked/node_modules/hello-world/lib/Release/Hello.framework/Modules",
10061+
"app.asar.unpacked/node_modules/hello-world/lib/Release/Hello.framework/Versions/Current",
1005210062
"app.asar.unpacked/node_modules/hello-world/lib/Release/Hello.framework/Versions/A/Hello",
1005310063
"app.asar.unpacked/node_modules/hello-world/lib/Release/Hello.framework/Versions/A/Info.plist",
1005410064
"app.asar.unpacked/node_modules/hello-world/lib/Release/Hello.framework/Versions/A/Modules/Hello.abi.json",
@@ -10078,6 +10088,7 @@ exports[`unpackDir 2`] = `
1007810088
"files": {
1007910089
"file-symlink2": {
1008010090
"link": "assets/file2",
10091+
"unpacked": true,
1008110092
},
1008210093
"file1": {
1008310094
"size": 4,
@@ -10091,6 +10102,7 @@ exports[`unpackDir 2`] = `
1009110102
"files": {
1009210103
"file-symlink1": {
1009310104
"link": "assets/file1",
10105+
"unpacked": true,
1009410106
},
1009510107
"file3": {
1009610108
"size": 4,
@@ -10192,6 +10204,7 @@ exports[`unpackDir one 2`] = `
1019210204
"files": {
1019310205
"file-symlink2": {
1019410206
"link": "assets/file2",
10207+
"unpacked": true,
1019510208
},
1019610209
"file1": {
1019710210
"size": 4,
@@ -10205,6 +10218,7 @@ exports[`unpackDir one 2`] = `
1020510218
"files": {
1020610219
"file-symlink1": {
1020710220
"link": "assets/file1",
10221+
"unpacked": true,
1020810222
},
1020910223
"file3": {
1021010224
"size": 4,

0 commit comments

Comments
 (0)