-
Notifications
You must be signed in to change notification settings - Fork 147
Add BEP038-compliant atlas examples of commonly used publicly available atlases #518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add BEP038-compliant atlas examples of commonly used publicly available atlases #518
Conversation
Add seven atlas examples following BEP038 specification: - atlas-AAL - atlas-Destrieux - atlas-DiFuMo (two different scales) - atlas-HarvardOxford (probseg and dseg) - atlas-Juelich (probseg and dseg) - atlas-Schaefer (two different scales) - atlas-Talairach These examples demonstrate various atlas structures and can be used for testing and validation of BEP038 implementations. However, they are most likely not fully compliant yet as some of the metadata might be missing/inaccurate and some files might have to be re-arranged.
tsalo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a few initial comments, but I think it'll be easier to review this once a couple of issues with the schema are fixed in the BEP's BIDS spec PR.
atlas-AAL/tpl-MNIColin27/anat/tpl-MNIColin27_atlas-AAL_res-1_dseg.tsv
Outdated
Show resolved
Hide resolved
atlas-AAL/tpl-MNIColin27/anat/tpl-MNIColin27_atlas-AAL_res-1_dseg.tsv
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you need SampleSize.
...ym/anat/tpl-MNI152NLin6Asym_atlas-Schaefer2018_scale-100_res-2_desc-7Networks_probseg.nii.gz
Outdated
Show resolved
Hide resolved
atlas-Talairach/tpl-MNI152NLin6Asym/anat/tpl-MNI152NLin6Asym_res-02_T1w.nii.gz
Outdated
Show resolved
Hide resolved
|
Hey @tsalo, thanks for the quick feedback and sorry for the problems! Those are indeed errors in the toolbox I use to create the examples. I can update this and address the outlined issues as soon as you say so. |
|
Hey again, I think I addressed all issues, adapted the code and regenerated all examples. I can push them whenever the work on the schema is ready. |
|
I don't know when @effigies will have time to make changes to the PR on the specification repo, so I recommend pushing your changes now. |
This commit updates the existing examples based on the reviews and adds a few new ones to outline different options.
|
Hey @tsalo, thanks for the information, I just |
|
The validation errors in https://github.com/bids-standard/bids-examples/actions/runs/18981357741/job/54214463305?pr=518 are helpful and most will need to be addressed. You'll still get errors on any |
This commit aims at addressing the validation errors occurred for the last version of the examples. This refers to: - samplesize is required - funding needs to be list - resolution missing from json - tpl skullstripped or not - naming pattern re seg and scale
|
Hey @tsalo, thanks for the pointer. I updated the code to hopefully address all validation errors (or at least most of them). This includes:
For some of the atlases some of the |
The previous versions of Harvard Oxford, Juelich and Talairach missed the SampleSize field.
|
Hey everyone, after the last round of edits, this is the status:
Focusing on the examples I worked on, I get the following errors:
I'm not so sure how to deal with the |
|
@PeerHerholz most of the remaining validator errors stem from the
EDIT: Never mind, that one was because it was atlas-Schaefer instead of atlas-Schaefer2018. @effigies fixed it. |
|
@PeerHerholz Feel free to make any further changes, just wanted to get everything in one place. |
Add seven atlas examples following BEP038 specification:
These examples demonstrate various atlas structures and can be used for testing and validation of BEP038 implementations. However, they are most likely not fully compliant yet as some of the metadata might be missing/inaccurate and some files might have to be re-arranged.