Merge pull request #1234 from bigcapitalhq/fix/banking-matching-single-id-query

fix(server): normalize single uncategorized transaction id query param

Author: abouolia

packages/server/src/modules/BankingMatching/BankingMatching.controller.ts

@@ -15,6 +15,7 @@ import {
   Post,
   Query,
 } from '@nestjs/common';
+import { castArray } from 'lodash';
 import { BankingMatchingApplication } from './BankingMatchingApplication';
 import { MatchBankTransactionDto } from './dtos/MatchBankTransaction.dto';
 import { GetMatchedTransactionsQueryDto } from './dtos/GetMatchedTransactionsQuery.dto';
@@ -48,8 +49,12 @@ export class BankingMatchingController {
     @Query('uncategorizedTransactionIds') uncategorizedTransactionIds: number[],
     @Query() filter: GetMatchedTransactionsQueryDto,
   ) {
+    const ids = castArray(uncategorizedTransactionIds ?? []).map((id) =>
+      Number(id),
+    );
+
     return this.bankingMatchingApplication.getMatchedTransactions(
-      uncategorizedTransactionIds ?? [],
+      ids,
       filter as any,
     );
   }

shared/sdk-ts/src/bank-rules.ts

@@ -1,4 +1,5 @@
 import type { ApiFetcher } from './fetch-utils';
+import { withNestedQuery } from './fetch-utils';
 import { paths } from './schema';
 import { OpForPath, OpQueryParams, OpRequestBody, OpResponseBody } from './utils';
 
@@ -160,7 +161,11 @@ export async function fetchMatchedTransactions(
     .method('get')
     .create();
   const ids = uncategorizedTransactionIds.map(String);
-  const { data } = await get({ uncategorizedTransactionIds: ids, ...query });
+  const { payload, init } = withNestedQuery({
+    uncategorizedTransactionIds: ids,
+    ...query,
+  });
+  const { data } = await get(payload, init);
   return data;
 }