Merge pull request #7303 from biolab/tree-rec-limit

Print "..." in deep subtrees of a Tree instead of raising RecursionError

Author: janezd

Orange/clustering/hierarchical.py

@@ -147,8 +147,11 @@ def __iter__(self):
         return iter((self.__value, self.__branches))
 
     def __repr__(self):
-        return ("{0.__name__}(value={1!r}, branches={2!r})"
-                .format(type(self), self.value, self.branches))
+        try:
+            return ("{0.__name__}(value={1!r}, branches={2!r})"
+                    .format(type(self), self.value, self.branches))
+        except RecursionError:
+            return ("{0.__name__}(...)".format(type(self)))
 
     @property
     def is_leaf(self):

Orange/clustering/tests/test_hierarchical.py

@@ -0,0 +1,27 @@
+import unittest
+import sys
+
+from Orange.clustering.hierarchical import Tree
+
+
+class TestTree(unittest.TestCase):
+    def test_repr(self):
+        tree = Tree(2)
+        self.assertEqual(repr(tree), "Tree(value=2, branches=())")
+
+        tree2 = Tree(3, (Tree(2), Tree(1)))
+        self.assertEqual(repr(tree2), "Tree(value=3, branches=(Tree(value=2, branches=()), Tree(value=1, branches=())))")
+
+        for i in range(100):
+            tree = Tree(i, (tree, tree))
+
+        rec_limit = sys.getrecursionlimit()
+        try:
+            sys.setrecursionlimit(30)
+            repr(tree)  # don't care about the result, just that it doesn't crash
+        finally:
+            sys.setrecursionlimit(rec_limit)
+
+
+if __name__ == "__main__":
+    unittest.main()

i18n/si/msgs.jaml

@@ -860,6 +860,7 @@ clustering/hierarchical.py:
         __hash: false
         def `__repr__`:
             {0.__name__}(value={1!r}, branches={2!r}): false
+            {0.__name__}(...): false
         _Tree__value: false
         _Tree__branches: false
     Cluster: false