📝 Formater reports file as to be formatted but formatter does nothing

[domiSchenk]

Environment information

CLI:
  Version:                      1.9.4
  Color support:                true

Platform:
  CPU Architecture:             x86_64
  OS:                           windows

Environment:
  BIOME_LOG_PATH:               unset
  BIOME_LOG_PREFIX_NAME:        unset
  BIOME_CONFIG_PATH:            unset
  NO_COLOR:                     unset
  TERM:                         unset
  JS_RUNTIME_VERSION:           "v20.12.1"
  JS_RUNTIME_NAME:              "node"
  NODE_PACKAGE_MANAGER:         unset

Biome Configuration:
  Status:                       Loaded successfully
  Formatter disabled:           false
  Linter disabled:              false
  Organize imports disabled:    false
  VCS disabled:                 false

Formatter:
  Format with errors:           false
  Indent style:                 Space
  Indent width:                 4
  Line ending:                  Lf
  Line width:                   140
  Attribute position:           Auto
  Bracket spacing:              BracketSpacing(true)
  Ignore:                       []
  Include:                      []

JavaScript Formatter:
  Enabled:                      false
  JSX quote style:              Double
  Quote properties:             AsNeeded
  Trailing commas:              All
  Semicolons:                   Always
  Arrow parentheses:            Always
  Bracket spacing:              BracketSpacing(true)
  Bracket same line:            false
  Quote style:                  Single
  Indent style:                 unset
  Indent width:                 unset
  Line ending:                  unset
  Line width:                   unset
  Attribute position:           Auto

JSON Formatter:
  Enabled:                      true
  Indent style:                 unset
  Indent width:                 unset
  Line ending:                  unset
  Line width:                   unset
  Trailing Commas:              unset

CSS Formatter:
  Enabled:                      true
  Indent style:                 unset
  Indent width:                 unset
  Line ending:                  unset
  Line width:                   unset
  Quote style:                  Double

GraphQL Formatter:
  Enabled:                      false
  Indent style:                 unset
  Indent width:                 unset
  Line ending:                  unset
  Line width:                   unset
  Bracket spacing:              unset
  Quote style:                  unset

Workspace:
  Open Documents:               0

Configuration

{
    "$schema": "https://biomejs.dev/schemas/1.9.4/schema.json",
    "vcs": { "enabled": true, "clientKind": "git", "useIgnoreFile": true, "defaultBranch": "main" },
    "files": {
        "ignoreUnknown": false,
        "ignore": [
            "**/*generated*",
            "./dist",
            "./coverage",
            "**/node_modules",
            "**/package.json",
            "**/package-lock.json",
            "**/.angular",
            "**/dx.generic.*-scheme.*",
            "**/.vs",
            "./.postcssrc.json",
            "./add-devextreme-license.js",
            "./angular.json",
            "./aspnetcore-https.js",
            "./db.json",
            "./devextreme.json",
            "./karma.conf.js",
            "./proxy.conf.js",
            "./routes.json",
            "./tailwind.config.js",
            "./tets.json",
            "./tsconfig.app.json",
            "./tsconfig.json",
            "./tsconfig.spec.json"
        ]
    },
    "formatter": {
        "enabled": true,
        "useEditorconfig": true,
        "formatWithErrors": false,
        "indentStyle": "space",
        "indentWidth": 4,
        "lineEnding": "lf",
        "lineWidth": 140,
        "attributePosition": "auto",
        "bracketSpacing": true,
        "ignore": []
    },
    "organizeImports": { "enabled": true },
    "linter": { "enabled": true, "rules": { "recommended": true } },
    "javascript": {
        "formatter": {
            "jsxQuoteStyle": "double",
            "quoteProperties": "asNeeded",
            "trailingCommas": "all",
            "semicolons": "always",
            "arrowParentheses": "always",
            "bracketSameLine": false,
            "quoteStyle": "single",
            "attributePosition": "auto",
            "bracketSpacing": true
        }
    },
    "overrides": [{ "include": ["*.html"] }]
}

Playground link

https://biomejs.dev/playground/?lineWidth=140&indentStyle=space&quoteStyle=single&indentWidth=4&code=LwAvACAAIgBUAGgAaQBzACAAaQBzACAAYQAgAFQAZQBzAHQAIABUAGkAdABsAGUAIQAgAEkAdAAnAHMAIABxAHUAaQB0AGUAIABpAG4AdABlAHIAZQBzAHQAaQBuAGcALgAiAAoALwAvACAATwB1AHQAcAB1AHQAOgAgACIAdABoAGkAcwAtAGkAcwAtAGEALQB0AGUAcwB0AC0AdABpAHQAbABlAC0AaQB0AHMALQBxAHUAaQB0AGUALQBpAG4AdABlAHIAZQBzAHQAaQBuAGcAIgAKAGUAeABwAG8AcgB0ACAAZgB1AG4AYwB0AGkAbwBuACAAZwBlAG4AZQByAGEAdABlAFMAbAB1AGcAKAB0AGUAeAB0ADoAIABzAHQAcgBpAG4AZwAsACAAcwBlAHAAYQByAGEAdABvAHIAIAA9ACAAJwAtACcAKQA6ACAAcwB0AHIAaQBuAGcAIAB7AAoAIAAgACAAIAAvAC8AIABDAG8AbgB2AGUAcgB0ACAAdABvACAAbABvAHcAZQByAGMAYQBzAGUACgAgACAAIAAgAGwAZQB0ACAAcwBsAHUAZwAgAD0AIAB0AGUAeAB0AC4AdABvAEwAbwB3AGUAcgBDAGEAcwBlACgAKQA7AAoACgAgACAAIAAgAC8ALwAgAFIAZQBtAG8AdgBlACAAcwBwAGUAYwBpAGEAbAAgAGMAaABhAHIAYQBjAHQAZQByAHMACgAgACAAIAAgAHMAbAB1AGcAIAA9ACAAcwBsAHUAZwAuAHIAZQBwAGwAYQBjAGUAKAAvAFsAXgBcAHcAXABzAC0AXQAvAGcALAAgACcAJwApADsACgAKACAAIAAgACAALwAvACAAUgBlAHAAbABhAGMAZQAgAHMAcABhAGMAZQBzACAAYQBuAGQAIAB1AG4AZABlAHIAcwBjAG8AcgBlAHMAIAB3AGkAdABoACAAdABoAGUAIABjAHUAcwB0AG8AbQAgAHMAZQBwAGEAcgBhAHQAbwByAAoAIAAgACAAIABjAG8AbgBzAHQAIABzAGUAcABhAHIAYQB0AG8AcgBSAGUAZwBlAHgAIAA9ACAALwBbAFwAcwBfAF0AKwAvAGcAOwAKACAAIAAgACAAcwBsAHUAZwAgAD0AIABzAGwAdQBnAC4AcgBlAHAAbABhAGMAZQAoAHMAZQBwAGEAcgBhAHQAbwByAFIAZQBnAGUAeAAsACAAcwBlAHAAYQByAGEAdABvAHIAKQA7AAoACgAgACAAIAAgAC8ALwAgAFIAZQBtAG8AdgBlACAAbQB1AGwAdABpAHAAbABlACAAcwBlAHAAYQByAGEAdABvAHIAcwAKACAAIAAgACAAYwBvAG4AcwB0ACAAbQB1AGwAdABpAHAAbABlAFMAZQBwAGEAcgBhAHQAbwByAFIAZQBnAGUAeAAgAD0AIABuAGUAdwAgAFIAZQBnAEUAeABwACgAYAAkAHsAcwBlAHAAYQByAGEAdABvAHIAfQArAGAALAAgACcAZwAnACkAOwAKACAAIAAgACAAcwBsAHUAZwAgAD0AIABzAGwAdQBnAC4AcgBlAHAAbABhAGMAZQAoAG0AdQBsAHQAaQBwAGwAZQBTAGUAcABhAHIAYQB0AG8AcgBSAGUAZwBlAHgALAAgAHMAZQBwAGEAcgBhAHQAbwByACkAOwAKAAoAIAAgACAAIAAvAC8AIABUAHIAaQBtACAAbABlAGEAZABpAG4AZwAgAGEAbgBkACAAdAByAGEAaQBsAGkAbgBnACAAcwBlAHAAYQByAGEAdABvAHIAcwAKACAAIAAgACAAYwBvAG4AcwB0ACAAdAByAGkAbQBTAGUAcABhAHIAYQB0AG8AcgBSAGUAZwBlAHgAIAA9ACAAbgBlAHcAIABSAGUAZwBFAHgAcAAoAGAAXgAkAHsAcwBlAHAAYQByAGEAdABvAHIAfQArAHwAJAB7AHMAZQBwAGEAcgBhAHQAbwByAH0AKwAkAGAALAAgACcAZwAnACkAOwAKACAAIAAgACAAcwBsAHUAZwAgAD0AIABzAGwAdQBnAC4AcgBlAHAAbABhAGMAZQAoAHQAcgBpAG0AUwBlAHAAYQByAGEAdABvAHIAUgBlAGcAZQB4ACwAIAAnACcAKQA7AAoACgAgACAAIAAgAHIAZQB0AHUAcgBuACAAcwBsAHUAZwA7AAoAfQAKAA%3D%3D

Code of Conduct

• I agree to follow Biome's Code of Conduct

[ematipico]

@domiSchenk you'll have to provide more information to us. The title is very cryptic and the playground doesn't show any additional information.

[github-actions]

Hello @domiSchenk, please provide a minimal reproduction. You can use one of the following options:

• Provide a link to our playground, if it's applicable.
• Provide a link to GitHub repository. To easily create a reproduction, you can use our interactive CLI via npm create @biomejs/biome-reproduction

Issues marked with S-Needs repro will be closed if they have no activity within 3 days.

[domiSchenk]

@ematipico omg you are fast :-D

here a repo that shows the problem:
https://github.com/domiSchenk/biome-repro-1739267746150

test.ts has a formatter error. interestingly the error does not show up on index.ts.

i how this helps find out whats the probelm

here a image of the output i get

[ematipico]

The original file has carriage returns as newlines cr, and Biome replaces them with line feed lf because it is its default. It's working as expected as per your configuration.

[domiSchenk]

ahh looks like the VS code extension formatter doesn't do it.

biome check --write
fixes the file but vs code formatter (its biome) doesn't.

in the test repo does the vs code formatter replace the CR with the LF?

[ematipico]

The test repo doesn't contain any VSCode settings, which means that the editor will use the user settings. Those settings differ from machine to machine, from user to user.

The result I will get from my machine will be different from yours.

I am closing the issue as it's not a Biome issue, and it's probably a VSCode settings issue.

[domiSchenk]

so the biomejs.biome formattor does not use boime.json file to format the files?
if it would, should it replace the endings according to the config file?

 "[typescript]": {
        "editor.defaultFormatter": "biomejs.biome"
    },

[lveillard]

I have a similar issue so easy to reproduce.

I just have a test.json with the content {"A": 'a'} it formats correctly the spaces but not the double quoites, it just reports as an error.

Doing Format Document (Forced) does work like prettier/eslint, but

biome check --write test.json

Throws an error but does not format it.

I added {formatter.formatWithErrors: true} and still not working.

Same when the keys are stated without the quotes, i would expect automatic correction but the formatter does nothing unless using the forced option

[ematipico]

@lveillard why would you expect correct formatting? Single quotes in JSON files aren't valid by spec.