fix(formatter): do not break properties of type annotation in function parameters #5174
+100
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-Formatter
…n parameters Signed-off-by: Naoki Ikeguchi <[email protected]>
siketyan
force-pushed
the
fix/GH-2406
branch
from
8b1b041 to
4da4228
Compare
CodSpeed Performance ReportMerging #5174 will not alter performanceComparing Summary
|
dyc3
approved these changes
Feb 22, 2025
| "@biomejs/biome": patch | ||
| --- | ||
|
|
||
| Fixed properties of object type annotation in function parameters are expanded, which is inconsistent with Prettier. |
There was a problem hiding this comment.
nit:
Suggested change
| Fixed properties of object type annotation in function parameters are expanded, which is inconsistent with Prettier. | |
| Fixed properties of object type annotation in function parameters are expanded, which was inconsistent with Prettier. |
Might be good to also link the fixed issue too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #2406
Prettier seems not breaking properties of a type annotation in function parameters. This pull request adds an exception to formatting object-like nodes to be consistent with Prettier.
Test Plan
Snapshot tests added.