Pin additional dependency versions to make builds reproducible #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems that you can't install older packages on debian, so pinning the package versions like that isn't really helpful. We'll probably need to build those libraries too and add them to the pyinstaller stuff. |
|
Dropped the package version pinning. I'm working on either excluding them from the result, or deterministically building them ourselves. |
achow101
force-pushed
the
lock-deps
branch
3 times, most recently
from
2e3be57 to
1dc3439
Compare
Lock the poetry version to be used for builds using a requirements.txt file
Cython is needed for hidapi and we need to pin its version number for determistic builds. Added with `poetry add cython` which also updated the rest of the packages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds additional version pinning so that builds are more reproducible. Poetry for the build also has a fixed version number. Cython is now a dependency so that hidapi is built reproducibly.
Fixes #303