Skip to content

Commit 0d253d5

Browse files
committedMar 14, 2022
configure: Use modern way to set AR
This uses AM_PROG_AR to discover ar, which is the recommended way to do so. Among other advantages, it honors the AR environment variable (as set from the outside). The macro has been around since automake 1.11.2 (Dec 2011). This commit also removes code that discovers ranlib and strip. ranlib has been obsolete for decades (ar does its task now automatically), and anyway LT_INIT takes care of discovering it. The code we used to set STRIP was last mentioned in the automake 1.5 manual. Since automake 1.6 (Mar 2002), strip is discovered automatically when necessary (look for the *private* macro AM_PROG_INSTALL_STRIP in the automake manual).
1 parent ac83be3 commit 0d253d5

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed
 

‎.gitignore

+1
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@ coverage.*.html
4646

4747
src/libsecp256k1-config.h
4848
src/libsecp256k1-config.h.in
49+
build-aux/ar-lib
4950
build-aux/config.guess
5051
build-aux/config.sub
5152
build-aux/depcomp

‎configure.ac

+5-6
Original file line numberDiff line numberDiff line change
@@ -25,24 +25,23 @@ AC_CANONICAL_HOST
2525
AH_TOP([#ifndef LIBSECP256K1_CONFIG_H])
2626
AH_TOP([#define LIBSECP256K1_CONFIG_H])
2727
AH_BOTTOM([#endif /*LIBSECP256K1_CONFIG_H*/])
28-
AM_INIT_AUTOMAKE([foreign subdir-objects])
2928

30-
LT_INIT([win32-dll])
29+
# Require Automake 1.11.2 for AM_PROG_AR
30+
AM_INIT_AUTOMAKE([1.11.2 foreign subdir-objects])
3131

3232
# Make the compilation flags quiet unless V=1 is used.
3333
m4_ifdef([AM_SILENT_RULES], [AM_SILENT_RULES([yes])])
3434

3535
PKG_PROG_PKG_CONFIG
3636

37-
AC_PATH_TOOL(AR, ar)
38-
AC_PATH_TOOL(RANLIB, ranlib)
39-
AC_PATH_TOOL(STRIP, strip)
40-
4137
AC_PROG_CC
4238
if test x"$ac_cv_prog_cc_c89" = x"no"; then
4339
AC_MSG_ERROR([c89 compiler support required])
4440
fi
4541
AM_PROG_AS
42+
AM_PROG_AR
43+
44+
LT_INIT([win32-dll])
4645

4746
build_windows=no
4847

0 commit comments

Comments
 (0)
Please sign in to comment.