Skip to content

Commit 10461d8

Browse files
precompute_ecmult: Always compute all tables up to default WINDOW_G
Also simplify #ifdefs in generated file.
1 parent be6944a commit 10461d8

File tree

2 files changed

+32
-30
lines changed

2 files changed

+32
-30
lines changed

src/precompute_ecmult.c

+5-3
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ static void print_table(FILE *fp, const char *name, int window_g, const secp256k
3232

3333
j = 1;
3434
for(i = 3; i <= window_g; ++i) {
35-
fprintf(fp, "#if ECMULT_TABLE_SIZE(WINDOW_G) > %ld\n", ECMULT_TABLE_SIZE(i-1));
35+
fprintf(fp, "#if WINDOW_G > %d\n", i-1);
3636
for(;j < ECMULT_TABLE_SIZE(i); ++j) {
3737
fprintf(fp, ",S(%"PRIx32",%"PRIx32",%"PRIx32",%"PRIx32",%"PRIx32",%"PRIx32",%"PRIx32",%"PRIx32
3838
",%"PRIx32",%"PRIx32",%"PRIx32",%"PRIx32",%"PRIx32",%"PRIx32",%"PRIx32",%"PRIx32")\n",
@@ -57,6 +57,8 @@ static void print_two_tables(FILE *fp, int window_g) {
5757
}
5858

5959
int main(void) {
60+
/* Always compute all tables for window sizes up to 15. */
61+
int window_g = (ECMULT_WINDOW_SIZE < 15) ? 15 : ECMULT_WINDOW_SIZE;
6062
FILE* fp;
6163

6264
fp = fopen("src/precomputed_ecmult.c","w");
@@ -77,15 +79,15 @@ int main(void) {
7779
fprintf(fp, "#include \"ecmult.h\"\n");
7880
fprintf(fp, "#include \"precomputed_ecmult.h\"\n");
7981
fprintf(fp, "#define S(a,b,c,d,e,f,g,h,i,j,k,l,m,n,o,p) SECP256K1_GE_STORAGE_CONST(0x##a##u,0x##b##u,0x##c##u,0x##d##u,0x##e##u,0x##f##u,0x##g##u,0x##h##u,0x##i##u,0x##j##u,0x##k##u,0x##l##u,0x##m##u,0x##n##u,0x##o##u,0x##p##u)\n");
80-
fprintf(fp, "#if ECMULT_TABLE_SIZE(ECMULT_WINDOW_SIZE) > %ld\n", ECMULT_TABLE_SIZE(ECMULT_WINDOW_SIZE));
82+
fprintf(fp, "#if ECMULT_WINDOW_SIZE > %d\n", window_g);
8183
fprintf(fp, " #error configuration mismatch, invalid ECMULT_WINDOW_SIZE. Try deleting precomputed_ecmult.c before the build.\n");
8284
fprintf(fp, "#endif\n");
8385
fprintf(fp, "#ifdef EXHAUSTIVE_TEST_ORDER\n");
8486
fprintf(fp, "# error Cannot compile precomputed_ecmult.c in exhaustive test mode\n");
8587
fprintf(fp, "#endif /* EXHAUSTIVE_TEST_ORDER */\n");
8688
fprintf(fp, "#define WINDOW_G ECMULT_WINDOW_SIZE\n");
8789

88-
print_two_tables(fp, ECMULT_WINDOW_SIZE);
90+
print_two_tables(fp, window_g);
8991

9092
fprintf(fp, "#undef S\n");
9193
fclose(fp);

0 commit comments

Comments
 (0)