Skip to content

Commit 36b0adf

Browse files
committed
build: remove warning until it's reproducible
Also remove the interface it was attached to since it's no longer needed. This removal simplifies the next commit.
1 parent 9c8c4f4 commit 36b0adf

File tree

1 file changed

+2
-12
lines changed

1 file changed

+2
-12
lines changed

src/CMakeLists.txt

+2-12
Original file line numberDiff line numberDiff line change
@@ -55,11 +55,6 @@ if(SECP256K1_BUILD_STATIC)
5555
list(APPEND ${PROJECT_NAME}_installables secp256k1_static)
5656
endif()
5757

58-
add_library(binary_interface INTERFACE)
59-
target_compile_definitions(binary_interface INTERFACE
60-
$<$<C_COMPILER_ID:MSVC>:_CRT_SECURE_NO_WARNINGS>
61-
)
62-
6358
add_library(link_library INTERFACE)
6459
if(SECP256K1_BUILD_SHARED)
6560
target_link_libraries(link_library INTERFACE secp256k1)
@@ -69,21 +64,17 @@ endif()
6964

7065
if(SECP256K1_BUILD_BENCHMARK)
7166
add_executable(bench bench.c)
72-
target_link_libraries(bench binary_interface link_library)
67+
target_link_libraries(bench link_library)
7368
add_executable(bench_internal bench_internal.c ${internal_obj})
74-
target_link_libraries(bench_internal binary_interface)
7569
add_executable(bench_ecmult bench_ecmult.c ${internal_obj})
76-
target_link_libraries(bench_ecmult binary_interface)
7770
endif()
7871

7972
if(SECP256K1_BUILD_TESTS)
8073
add_executable(noverify_tests tests.c ${internal_obj})
81-
target_link_libraries(noverify_tests binary_interface)
8274
add_test(noverify_tests noverify_tests)
8375
if(NOT CMAKE_BUILD_TYPE STREQUAL "Coverage")
8476
add_executable(tests tests.c ${internal_obj})
8577
target_compile_definitions(tests PRIVATE VERIFY)
86-
target_link_libraries(tests binary_interface)
8778
add_test(tests tests)
8879
endif()
8980
endif()
@@ -92,13 +83,12 @@ if(SECP256K1_BUILD_EXHAUSTIVE_TESTS)
9283
# Note: do not include $<TARGET_OBJECTS:precomputed> in exhaustive_tests (it uses runtime-generated tables).
9384
add_executable(exhaustive_tests tests_exhaustive.c ${common_obj})
9485
target_compile_definitions(exhaustive_tests PRIVATE $<$<NOT:$<CONFIG:Coverage>>:VERIFY>)
95-
target_link_libraries(exhaustive_tests binary_interface)
9686
add_test(exhaustive_tests exhaustive_tests)
9787
endif()
9888

9989
if(SECP256K1_BUILD_CTIME_TESTS)
10090
add_executable(ctime_tests ctime_tests.c)
101-
target_link_libraries(ctime_tests binary_interface link_library)
91+
target_link_libraries(ctime_tests link_library)
10292
endif()
10393

10494
install(TARGETS ${${PROJECT_NAME}_installables}

0 commit comments

Comments
 (0)