Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit 6bed465

Browse files
committedDec 16, 2023
doc: Add ABI checking with check-abi.sh to the Release Process
1 parent 736a897 commit 6bed465

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed
 

‎doc/release-process.md

+8-4
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,11 @@ gcc -o ecdsa examples/ecdsa.c -I $dir/include -L $dir/lib*/ -l secp256k1 -Wl,-rp
3737

3838
## Regular release
3939

40-
1. Open a PR to the master branch with a commit (using message `"release: prepare for $MAJOR.$MINOR.$PATCH"`, for example) that
40+
1. Check the ABI compatibility with the [`check-abi.sh`](/tools/check-abi.sh) tool (installing the `abi-dumper` and `abi-compliance-checker` packages might be required):
41+
```shell
42+
tools/check-abi.sh
43+
```
44+
2. Open a PR to the master branch with a commit (using message `"release: prepare for $MAJOR.$MINOR.$PATCH"`, for example) that
4145
* finalizes the release notes in [CHANGELOG.md](../CHANGELOG.md) by
4246
* adding a section for the release (make sure that the version number is a link to a diff between the previous and new version),
4347
* removing the `[Unreleased]` section header, and
@@ -46,19 +50,19 @@ gcc -o ecdsa examples/ecdsa.c -I $dir/include -L $dir/lib*/ -l secp256k1 -Wl,-rp
4650
* if this is not a patch release
4751
* updates `_PKG_VERSION_*` and `_LIB_VERSION_*` in `configure.ac` and
4852
* updates `project(libsecp256k1 VERSION ...)` and `${PROJECT_NAME}_LIB_VERSION_*` in `CMakeLists.txt`.
49-
2. After the PR is merged, tag the commit and push it:
53+
3. After the PR is merged, tag the commit and push it:
5054
```
5155
RELEASE_COMMIT=<merge commit of step 1>
5256
git tag -s v$MAJOR.$MINOR.$PATCH -m "libsecp256k1 $MAJOR.$MINOR.$PATCH" $RELEASE_COMMIT
5357
git push git@github.com:bitcoin-core/secp256k1.git v$MAJOR.$MINOR.$PATCH
5458
```
55-
3. Open a PR to the master branch with a commit (using message `"release cleanup: bump version after $MAJOR.$MINOR.$PATCH"`, for example) that
59+
4. Open a PR to the master branch with a commit (using message `"release cleanup: bump version after $MAJOR.$MINOR.$PATCH"`, for example) that
5660
* sets `_PKG_VERSION_IS_RELEASE` to `false` and increments `_PKG_VERSION_PATCH` and `_LIB_VERSION_REVISION` in `configure.ac`,
5761
* increments the `$PATCH` component of `project(libsecp256k1 VERSION ...)` and `${PROJECT_NAME}_LIB_VERSION_REVISION` in `CMakeLists.txt`, and
5862
* adds an `[Unreleased]` section header to the [CHANGELOG.md](../CHANGELOG.md).
5963

6064
If other maintainers are not present to approve the PR, it can be merged without ACKs.
61-
4. Create a new GitHub release with a link to the corresponding entry in [CHANGELOG.md](../CHANGELOG.md).
65+
5. Create a new GitHub release with a link to the corresponding entry in [CHANGELOG.md](../CHANGELOG.md).
6266

6367
## Maintenance release
6468

0 commit comments

Comments
 (0)
Please sign in to comment.