Skip to content

Commit 6f54e69

Browse files
committed
Merge #841: Avoids a potentially shortening size_t to int cast in strauss_wnaf_
8893f42 Avoids a potentially shortening size_t to int cast in strauss_wnaf_ (Tim Ruffing) Pull request description: ACKs for top commit: sipa: ACK 8893f42. `np` and `no` shouldn't ever take on negative values. jonasnick: ACK 8893f42 elichai: ACK 8893f42 Tree-SHA512: 431a6b88c8db8c8883b35c9bc03c90e37ecd0b06c7ee01c5d83cca4a7f6fc1f3cfbbaa871a4a23374ce4cc5bcfb9502c7f2e2540f9f9db9535e47e48827b6af6
2 parents ac05f61 + 8893f42 commit 6f54e69

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/ecmult_impl.h

+3-3
Original file line numberDiff line numberDiff line change
@@ -443,7 +443,7 @@ struct secp256k1_strauss_state {
443443
struct secp256k1_strauss_point_state* ps;
444444
};
445445

446-
static void secp256k1_ecmult_strauss_wnaf(const secp256k1_ecmult_context *ctx, const struct secp256k1_strauss_state *state, secp256k1_gej *r, int num, const secp256k1_gej *a, const secp256k1_scalar *na, const secp256k1_scalar *ng) {
446+
static void secp256k1_ecmult_strauss_wnaf(const secp256k1_ecmult_context *ctx, const struct secp256k1_strauss_state *state, secp256k1_gej *r, size_t num, const secp256k1_gej *a, const secp256k1_scalar *na, const secp256k1_scalar *ng) {
447447
secp256k1_ge tmpa;
448448
secp256k1_fe Z;
449449
/* Splitted G factors. */
@@ -454,8 +454,8 @@ static void secp256k1_ecmult_strauss_wnaf(const secp256k1_ecmult_context *ctx, c
454454
int bits_ng_128 = 0;
455455
int i;
456456
int bits = 0;
457-
int np;
458-
int no = 0;
457+
size_t np;
458+
size_t no = 0;
459459

460460
for (np = 0; np < num; ++np) {
461461
if (secp256k1_scalar_is_zero(&na[np]) || secp256k1_gej_is_infinity(&a[np])) {

0 commit comments

Comments
 (0)