Skip to content

Commit 99bd335

Browse files
committed
Make int128 overflow test use secp256k1_[ui]128_mul
1 parent 3afce0a commit 99bd335

File tree

1 file changed

+3
-6
lines changed

1 file changed

+3
-6
lines changed

src/tests.c

+3-6
Original file line numberDiff line numberDiff line change
@@ -1977,8 +1977,7 @@ void run_int128_tests(void) {
19771977
secp256k1_uint128 res;
19781978

19791979
/* Check secp256k1_u128_accum_mul overflow */
1980-
secp256k1_u128_from_u64(&res, 0);
1981-
secp256k1_u128_accum_mul(&res, UINT64_MAX, UINT64_MAX);
1980+
secp256k1_u128_mul(&res, UINT64_MAX, UINT64_MAX);
19821981
secp256k1_u128_accum_mul(&res, UINT64_MAX, UINT64_MAX);
19831982
CHECK(secp256k1_u128_to_u64(&res) == 2);
19841983
CHECK(secp256k1_u128_hi_u64(&res) == 18446744073709551612U);
@@ -1987,8 +1986,7 @@ void run_int128_tests(void) {
19871986
secp256k1_int128 res;
19881987

19891988
/* Compute INT128_MAX = 2^127 - 1 with secp256k1_i128_accum_mul */
1990-
secp256k1_i128_from_i64(&res, 0);
1991-
secp256k1_i128_accum_mul(&res, INT64_MAX, INT64_MAX);
1989+
secp256k1_i128_mul(&res, INT64_MAX, INT64_MAX);
19921990
secp256k1_i128_accum_mul(&res, INT64_MAX, INT64_MAX);
19931991
CHECK(secp256k1_i128_to_i64(&res) == 2);
19941992
secp256k1_i128_accum_mul(&res, 4, 9223372036854775807);
@@ -1998,8 +1996,7 @@ void run_int128_tests(void) {
19981996
CHECK(secp256k1_i128_to_i64(&res) == INT64_MAX);
19991997

20001998
/* Compute INT128_MIN = - 2^127 with secp256k1_i128_accum_mul */
2001-
secp256k1_i128_from_i64(&res, 0);
2002-
secp256k1_i128_accum_mul(&res, INT64_MAX, INT64_MIN);
1999+
secp256k1_i128_mul(&res, INT64_MAX, INT64_MIN);
20032000
CHECK(secp256k1_i128_to_i64(&res) == INT64_MIN);
20042001
secp256k1_i128_accum_mul(&res, INT64_MAX, INT64_MIN);
20052002
CHECK(secp256k1_i128_to_i64(&res) == 0);

0 commit comments

Comments
 (0)