Skip to content

Commit bb36331

Browse files
committedDec 18, 2021
Simplify precompute_ecmult_print_*
1 parent 38cd84a commit bb36331

File tree

1 file changed

+8
-13
lines changed

1 file changed

+8
-13
lines changed
 

‎src/precompute_ecmult.c

+8-13
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
#include "ecmult.h"
2222
#include "ecmult_compute_table_impl.h"
2323

24-
static void print_table(FILE *fp, const char *name, int window_g, const secp256k1_ge_storage* table, int with_conditionals) {
24+
static void print_table(FILE *fp, const char *name, int window_g, const secp256k1_ge_storage* table) {
2525
int j;
2626
int i;
2727

@@ -32,36 +32,31 @@ static void print_table(FILE *fp, const char *name, int window_g, const secp256k
3232

3333
j = 1;
3434
for(i = 3; i <= window_g; ++i) {
35-
if (with_conditionals) {
36-
fprintf(fp, "#if ECMULT_TABLE_SIZE(WINDOW_G) > %ld\n", ECMULT_TABLE_SIZE(i-1));
37-
}
35+
fprintf(fp, "#if ECMULT_TABLE_SIZE(WINDOW_G) > %ld\n", ECMULT_TABLE_SIZE(i-1));
3836
for(;j < ECMULT_TABLE_SIZE(i); ++j) {
3937
fprintf(fp, ",S(%"PRIx32",%"PRIx32",%"PRIx32",%"PRIx32",%"PRIx32",%"PRIx32",%"PRIx32",%"PRIx32
4038
",%"PRIx32",%"PRIx32",%"PRIx32",%"PRIx32",%"PRIx32",%"PRIx32",%"PRIx32",%"PRIx32")\n",
4139
SECP256K1_GE_STORAGE_CONST_GET(table[j]));
4240
}
43-
if (with_conditionals) {
44-
fprintf(fp, "#endif\n");
45-
}
41+
fprintf(fp, "#endif\n");
4642
}
4743
fprintf(fp, "};\n");
4844
}
4945

50-
static void print_two_tables(FILE *fp, int window_g, const secp256k1_ge *g, int with_conditionals) {
46+
static void print_two_tables(FILE *fp, int window_g) {
5147
secp256k1_ge_storage* table = malloc(ECMULT_TABLE_SIZE(window_g) * sizeof(secp256k1_ge_storage));
5248
secp256k1_ge_storage* table_128 = malloc(ECMULT_TABLE_SIZE(window_g) * sizeof(secp256k1_ge_storage));
5349

54-
secp256k1_ecmult_compute_two_tables(table, table_128, window_g, g);
50+
secp256k1_ecmult_compute_two_tables(table, table_128, window_g, &secp256k1_ge_const_g);
5551

56-
print_table(fp, "secp256k1_pre_g", window_g, table, with_conditionals);
57-
print_table(fp, "secp256k1_pre_g_128", window_g, table_128, with_conditionals);
52+
print_table(fp, "secp256k1_pre_g", window_g, table);
53+
print_table(fp, "secp256k1_pre_g_128", window_g, table_128);
5854

5955
free(table);
6056
free(table_128);
6157
}
6258

6359
int main(void) {
64-
const secp256k1_ge g = SECP256K1_G;
6560
const int window_g_13 = 4;
6661
const int window_g_199 = 8;
6762
FILE* fp;
@@ -101,7 +96,7 @@ int main(void) {
10196
fprintf(fp, "#else /* !defined(EXHAUSTIVE_TEST_ORDER) */\n");
10297
fprintf(fp, "#define WINDOW_G ECMULT_WINDOW_SIZE\n");
10398

104-
print_two_tables(fp, ECMULT_WINDOW_SIZE, &g, 1);
99+
print_two_tables(fp, ECMULT_WINDOW_SIZE);
105100

106101
fprintf(fp, "#endif /* defined(EXHAUSTIVE_TEST_ORDER) */\n");
107102
fprintf(fp, "#undef S\n");

0 commit comments

Comments
 (0)
Please sign in to comment.