Skip to content

Commit d1e48e5

Browse files
committed
refactor: Make 64-bit shift explicit
This change fixes MSVC level-3 warning C4334. See: https://learn.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-3-c4334 Required to enable level 3 warnings (/W3).
1 parent b2e29e4 commit d1e48e5

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

src/ecmult_impl.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -683,7 +683,7 @@ static int secp256k1_ecmult_pippenger_batch(const secp256k1_callback* error_call
683683
}
684684
state_space->ps = (struct secp256k1_pippenger_point_state *) secp256k1_scratch_alloc(error_callback, scratch, entries * sizeof(*state_space->ps));
685685
state_space->wnaf_na = (int *) secp256k1_scratch_alloc(error_callback, scratch, entries*(WNAF_SIZE(bucket_window+1)) * sizeof(int));
686-
buckets = (secp256k1_gej *) secp256k1_scratch_alloc(error_callback, scratch, (1<<bucket_window) * sizeof(*buckets));
686+
buckets = (secp256k1_gej *) secp256k1_scratch_alloc(error_callback, scratch, ((size_t)1 << bucket_window) * sizeof(*buckets));
687687
if (state_space->ps == NULL || state_space->wnaf_na == NULL || buckets == NULL) {
688688
secp256k1_scratch_apply_checkpoint(error_callback, scratch, scratch_checkpoint);
689689
return 0;

src/tests.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -2221,7 +2221,7 @@ static void scalar_test(void) {
22212221
for (i = 0; i < 100; ++i) {
22222222
int low;
22232223
int shift = 1 + secp256k1_testrand_int(15);
2224-
int expected = r.d[0] % (1 << shift);
2224+
int expected = r.d[0] % (1ULL << shift);
22252225
low = secp256k1_scalar_shr_int(&r, shift);
22262226
CHECK(expected == low);
22272227
}

0 commit comments

Comments
 (0)