remove needless save/load

Author: benma

src/secp256k1.c

@@ -486,8 +486,8 @@ int secp256k1_ecdsa_sign(const secp256k1_context* ctx, secp256k1_ecdsa_signature
 }
 
 /* Compute an ec commitment tweak as hash(pubkey, data). */
-static int secp256k1_ec_commit_tweak(const secp256k1_context *ctx, unsigned char *tweak32, const secp256k1_pubkey *pubkey, const unsigned char *data, size_t data_size) {
-    secp256k1_ge p;
+static int secp256k1_ec_commit_tweak(unsigned char *tweak32, const secp256k1_ge *pubkey, const unsigned char *data, size_t data_size) {
+    secp256k1_ge p = *pubkey;
     unsigned char rbuf[33];
     size_t rbuf_size = sizeof(rbuf);
     secp256k1_sha256 sha;
@@ -496,9 +496,6 @@ static int secp256k1_ec_commit_tweak(const secp256k1_context *ctx, unsigned char
         /* That's probably not what the caller wanted */
         return 0;
     }
-    if(!secp256k1_pubkey_load(ctx, &p, pubkey)) {
-        return 0;
-    }
     secp256k1_eckey_pubkey_serialize(&p, rbuf, &rbuf_size, 1);
 
     secp256k1_sha256_initialize(&sha);
@@ -517,11 +514,9 @@ static int secp256k1_ec_commit_tweak_from_seckey(
     size_t data_size) {
     secp256k1_gej rp;
     secp256k1_ge r;
-    secp256k1_pubkey pubkey_tmp;
     secp256k1_ecmult_gen(&ctx->ecmult_gen_ctx, &rp, seckey);
     secp256k1_ge_set_gej(&r, &rp);
-    secp256k1_pubkey_save(&pubkey_tmp, &r);
-    return secp256k1_ec_commit_tweak(ctx, tweak32, &pubkey_tmp, data, data_size);
+    return secp256k1_ec_commit_tweak(tweak32, &r, data, data_size);
 }
 
 int secp256k1_ecdsa_sign_to_contract(const secp256k1_context* ctx, secp256k1_ecdsa_signature *signature, const unsigned char *msg32, const unsigned char *seckey, secp256k1_nonce_function noncefp, const void* noncedata, const unsigned char* s2c_data32) {