Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fork observer deployment issues #684

Open
pinheadmz opened this issue Feb 20, 2025 · 3 comments
Open

fork observer deployment issues #684

pinheadmz opened this issue Feb 20, 2025 · 3 comments
Assignees

Comments

@pinheadmz
Copy link
Contributor

  1. there's a race condition where FO won't see all the tanks when it starts up, it should probably wait until all tanks are alive and running before we deploy.
  2. it should be namespace restricted to default so it doesnt pick up armada tanks
  3. it should be set to restart on failure so it can be manually restarted with a kill
@willcl-ark
Copy link
Contributor

How did 1) manifest?

I thought fork observer was quite resilient to configured nodes not being available and would continually try to (re)connect…

Ping @0xB10C

@0xB10C
Copy link
Contributor

0xB10C commented Feb 21, 2025

Correct, it will try to reconnect to nodes, but not try to get the node version again if it failed at the beginning (this is done as the RPC getnetworkinfo is an optional RPC for fork-observer, and not a strict requirement). See https://github.com/0xB10C/fork-observer/blob/6f6d33f0f8cbdd201f9f062e0638a47750871ff3/src/main.rs#L777-L813

It retries for 5 times and waits 10s after each failed attempt. Since you need the versions for the warnet game, might want to start fork-observer after the nodes are RPC reachable

@0xB10C
Copy link
Contributor

0xB10C commented Feb 21, 2025

If you have fork-observer logs, it should also tell you why it didn't get the versions for the nodes

@willcl-ark willcl-ark self-assigned this Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants