Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

28.1 image isn't on dockerhub, and i think the commit is wrong #705

Closed
pinheadmz opened this issue Mar 31, 2025 · 0 comments · Fixed by #706
Closed

28.1 image isn't on dockerhub, and i think the commit is wrong #705

pinheadmz opened this issue Mar 31, 2025 · 0 comments · Fixed by #706

Comments

@pinheadmz
Copy link
Contributor

We should build 28.1 and push to dockerhub but first we have to fix this...

Expected commits:

28.0: 110183746150428e6385880c79f8c5733b1361ba

28.1: 32efe850438ef22e2de39e562af557872a402c31

Actual commits:

warnet/docker-bake.hcl

Lines 79 to 85 in ff34691

target "bitcoin-28" {
inherits = ["autogen-base"]
tags = ["bitcoindevproject/bitcoin:28.0"]
args = {
COMMIT_SHA = "110183746150428e6385880c79f8c5733b1361ba"
}
}

warnet/docker-bake.hcl

Lines 71 to 77 in ff34691

target "bitcoin-master" {
inherits = ["cmake-base"]
tags = ["bitcoindevproject/bitcoin:28.1"]
args = {
COMMIT_SHA = "bd0ee07310c3dcdd08633c69eac330e2e567b235"
}
}

--> git show v28.0
tag v28.0
Tagger: Ava Chow <github@achow101.com>
Date:   Tue Oct 1 13:30:33 2024 -0400

Bitcoin Core 28.0 final

Tree-SHA512: b42948a04d4250f2c9ef3331a39a4c3d7de9ceb9f4f294dd283599d08f3e2b7147297ef9ec1c4276e291a015fc2daa5a72c1f1c33fb517e8ea5c740c4459bf32
-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEFSgSMAeFyWRE0zNNF1ZXMuCOXkEFAmb8MbkACgkQF1ZXMuCO
XkFXZQ//agEIXSU9/q0CrZ7SdTa+vNWHXoahcwHutP7lpz65h1Z6sCOJ6FQdjr0J
aIQJ1dNlC1DnoyQu6JNRWlc5cHt13DcvKt40a5M/jAf8TVE9G9plTbQdkc+cy/B6
3IrwrTM6SyTuFMz1qdf6PzEZfUmXZU5c9AxJryp1dXjxTKlMNlXAIx6P/bcqgMID
wAEuYZDZLjTZ/bgabPVbD0en3wOsmDSI5lFeyP/0WieCbmh7yHQWxaeWLDX74n9y
PEatKEnIW037NtIDyIEWJTbKCAJQXH6zRiL+luSwEdgayV5OyjZHgoaWgtSz7VRf
mtK92Vd8YG29eIUVsVGYcOal+/v6mk08a+/2jbQIIRPIa8Uv/vb70+SVDZhdMpkz
SBsE0G2/dzJNCn76EA2Pz446GWWHn0xfYU4TiYahsC48tEJKv9zfbW7DEplWT/2R
+BIAEfi+sZ0ZsMU4BXlSJ2jfWOux4mFJs2u+gQ+6nHcp6NPGPwIw3B1+HMvcCh7P
7EIKRL26RfZAV+ox1GSqdHrsS1xXkXivYGXiGPpNT6lHaWjknJPQqlHFEEdPaxBz
VsXq3BgZ8IXZ3xbC4Yk5Rzh8ctQykbkYsuqZ9+AvwbPEmAzqAeFsMp9/xAKSv2R6
z3QlxWCeKIGdS6IhZ5M2m+0Bo1YXHt1tCTiSUnIXlNU1+LTHO7w=
=Mz8y
-----END PGP SIGNATURE-----

commit 110183746150428e6385880c79f8c5733b1361ba (tag: v28.0)
Merge: 1147e72953 5de225f5c1
Author: Ava Chow <github@achow101.com>
Date:   Tue Oct 1 13:30:02 2024 -0400

    Merge bitcoin/bitcoin#30959: [28.x] backports and finalize
    
    5de225f5c145368f70cb5f870933bcf9df6b92c8 doc: 28.0 Release Notes (Ava Chow)
    98745e03ffc9f69f901b827e19e4d8d645a27112 doc: generate manpages (Ava Chow)
    5feef9ce7ebf608e45aa9682512599494c0d46d8 build: Bump to 28.0 (Ava Chow)
    7fcd7b85c64ffbcd67d8ff1add46d258b26b2029 validation: Disable CheckForkWarningConditions for background chainstate (Martin Zumsande)
    e24a25d882ba8c8dacc1eede6b9373fe7601f85b test: Use shell builtins in run_command test case (Ava Chow)
    
    Pull request description:
    
      * #30952
      * #30962
      * Finalize 28.0 (or rc3 if additional backports are needed)
    
    ACKs for top commit:
      sipa:
        utACK 5de225f5c145368f70cb5f870933bcf9df6b92c8
    
    Tree-SHA512: b42948a04d4250f2c9ef3331a39a4c3d7de9ceb9f4f294dd283599d08f3e2b7147297ef9ec1c4276e291a015fc2daa5a72c1f1c33fb517e8ea5c740c4459bf32

--> git show v28.1
tag v28.1
Tagger: Ava Chow <github@achow101.com>
Date:   Tue Jan 7 13:33:40 2025 -0500

Bitcoin Core 28.1 final

Tree-SHA512: c7a624b4c166f4322011d98d1ca814ae98eaf5fd2481a507cd65a50216f1abbb91f8643508ce81f64f8b10fa2210db1722254c343253f2a950b9c64667735e9b
-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEFSgSMAeFyWRE0zNNF1ZXMuCOXkEFAmd9c4QACgkQF1ZXMuCO
XkGbGw//TlLKQ7Q0xfKumqBAI7OET3iXltJDYdLHLDDuomqY8DdhX4T3Dv5JGdw0
OVl31GlK8Da/J0EnKO2Sy5leZbeg37iHQzmv55uLlXqqydO4YOQi3vDtVJSKPLV1
SVPMTMOmKi0H0DDKwTKdck07LXtug41a6h/VZJin7s1SJzdLM7h4kN+Nx2RvlPBR
YF9a6hYPTtIeMlCU0bP/3Iatq7upFeexTf21q8yauDkKvVnz0wH62joXxaJBV9qL
dgNATLSH81AyTvjQNRRvgEDLdDSqAbGbgwTrCGIY87Dogy0Lq28l87tK0rhMCVFB
8D/AwikqrteOlLw6th5t9kBxeD3IKW5aDZ4Qgj3tkrArAkoNnryECE5SXFFtjVJg
pkjXJRhPN9xz34bRPAT2A1MNHKk1ndXYVm5C4WoJigvvmnVuSI7iofjIjDGJxuUu
VrwY8XsRWDMyiJHxgIByamElZ4cJXyfno9uL/0VmAEKmaigNM7jCueTxSSTjjtmb
CE5FdnVzn+DyvZn1L4sZsDPYwTcySXsQ5LescEeBxRWVuXdKPDIqC7QEB7ICvcGv
li7CQ/pqxIAcWODnqUHZ7U9/LffiZlSHYoMu2Wj2M4H/+jwnA6JxR1iCoLJV2PMW
5HmlqKpY54HhFguw8rnu9Igw8QCI58Dg1/yhHSpRh0XS67Xw2W8=
=i6y/
-----END PGP SIGNATURE-----
-----BEGIN OPENTIMESTAMPS GIT TIMESTAMP-----

AQHwIFa89kSJV744OVy/o8DA+V5u66X3LZgN9CPtzWVtIAEWCP/wEDo5FFiAi39V
yYIH/Yp0I6QI8QRnfXOH8AjqbKa5fZNlwgCD3+MNLvkMjiMiaHR0cHM6Ly9idGMu
Y2FsZW5kYXIuY2F0YWxsYXh5LmNvbf/wEFd9qh19cIzqNvI5rxQCHmII8SBsrmFa
2TK8iNobs+WCZbUniZVbedFBONfuVGDdDmVpxwjxBGd9c4fwCDA2U5hqiDK/AIPf
4w0u+QyOKShodHRwczovL2Zpbm5leS5jYWxlbmRhci5ldGVybml0eXdhbGwuY29t
//AQrnTyQf1jnOsXR7Hu/nYVDgjxIKo+J4ZYkhrtdd0aPPJVUyAtUUcjS8opLwQd
7C66mgJaCPEEZ31ziPAIwYHczPx0kt0Ag9/jDS75DI4sK2h0dHBzOi8vYm9iLmJ0
Yy5jYWxlbmRhci5vcGVudGltZXN0YW1wcy5vcmfwELFj6NnyDbfT6qInzgC3MeEI
8SCyY/pFXs7/twI8E9l43qnOfwbUYPuqrPwFK65e44a6jwjxBGd9c4fwCLo+a3zh
4YZtAIPf4w0u+QyOLi1odHRwczovL2FsaWNlLmJ0Yy5jYWxlbmRhci5vcGVudGlt
ZXN0YW1wcy5vcmc=
-----END OPENTIMESTAMPS GIT TIMESTAMP-----

commit 32efe850438ef22e2de39e562af557872a402c31 (tag: v28.1)
Merge: 6db725662d 36314b8da2
Author: Ava Chow <github@achow101.com>
Date:   Tue Jan 7 13:32:56 2025 -0500

    Merge bitcoin/bitcoin#31594: [28.x] 28.1 backports and final changes
    
    36314b8da2ee65afd5636fa830d436c5c22bd260 doc: Update 28.1 release notes (MarcoFalke)
    58910279dcfd989a1712b3dc39a272ff3fbe1136 doc: generate 28.1 manpages (Ava Chow)
    6a68ef9bfb39b27d480d4091b60d1c7f9f2d8690 build: bump to 28.1 (Ava Chow)
    5b368f88a9fddd0cd48fb014ff9694c555129996 depends: Fix CXXFLAGS on NetBSD (Hennadii Stepanov)
    05cd448e3328181d3fe1662bcd7af82cb51833a7 test: generateblocks called by multiple threads (MarcoFalke)
    621c634b7fe14fbf151cd222eeaade3505059249 rpc: Extend scope of validation mutex in generateblock (MarcoFalke)
    
    Pull request description:
    
      Backports:
    
      - #31502
      - #31563
    
    ACKs for top commit:
      glozow:
        reACK 36314b8da2ee65afd5636fa830d436c5c22bd260
      achow101:
        ACK 36314b8da2ee65afd5636fa830d436c5c22bd260
    
    Tree-SHA512: c7a624b4c166f4322011d98d1ca814ae98eaf5fd2481a507cd65a50216f1abbb91f8643508ce81f64f8b10fa2210db1722254c343253f2a950b9c64667735e9b


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant