Skip to content

Commit 4c897bf

Browse files
bigspiderjonatack
andauthored
Apply suggestions from code review
Co-authored-by: Jon Atack <[email protected]>
1 parent 299a412 commit 4c897bf

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

bip-0388.mediawiki

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
RECENT CHANGES:
2-
* (06 Nov 2024) Added <tt>musig</tt> key placeholders
2+
* (06 Nov 2024) Added support for <tt>musig</tt> key placeholders in descriptor templates
33
44
<pre>
55
BIP: 388
@@ -83,7 +83,7 @@ We set two fundamental design goals:
8383
* Minimize the amount of information that is shown on screen - so that the user can actually validate it.
8484
* Minimize the number of times the user has to validate such information.
8585
86-
Designing a secure protocol for the coordination of a descriptor wallet among distant parties is also a challenging problem that is out of scope in this document. See [[bip-0129.mediawiki|BIP-129 (Bitcoin Secure Multisig Setup)]] for an approach designed for multisig wallets. Regardless of the approach, the ability for the user to carefully verify all the details of the spending policies using the hardware signer's screen is a prerequisite for security in adversarial environments.
86+
Designing a secure protocol for the coordination of a descriptor wallet among distant parties is also a challenging problem that is out of the scope of this document. See [[bip-0129.mediawiki|BIP-129 (Bitcoin Secure Multisig Setup)]] for an approach designed for multisig wallets. Regardless of the approach, the ability for the user to carefully verify all the details of the spending policies using the hardware signer's screen is a prerequisite for security in adversarial environments.
8787

8888
=== Policy registration as a solution ===
8989

@@ -173,7 +173,7 @@ Note that while [[bip-0389.mediawiki|BIP-389]] allows multipath <tt>/<NUM;NUM;..
173173

174174
Each <tt>KEY</tt> expression always correspond to a precise public key in the final bitcoin Script. Therefore, all the derivation steps in the BIP-32 hierarchy are included in a <tt>KEY</tt> expression.
175175

176-
Each <tt>KP</tt> (key placeholder) expressions, on the other hand, maps to the root of all the corresponding public keys for all the possible UTXOs that belong to the account represented in the wallet policy. Therefore, no derivation steps are allowed in a <tt>KP</tt> expression.
176+
Each <tt>KP</tt> (key placeholder) expression, on the other hand, maps to the root of all the corresponding public keys for all the possible UTXOs that belong to the account represented in the wallet policy. Therefore, no derivation steps are allowed in a <tt>KP</tt> expression.
177177

178178
A <tt>KI</tt> (key index) <tt>@i</tt> for some number ''i'' represents the ''i''-th key in the vector of key information items (which must be of size at least ''i + 1'', or the wallet policy is invalid).
179179

0 commit comments

Comments
 (0)