-
Couldn't load subscription status.
- Fork 411
bump(bdk_chain): rusqlite to 0.36.0 #2002
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that unilaterally bumping the rusqlite dependency just in BDK is a good idea, as it will result in incompatibility with other crates in the rust-bitcoin space. Unfortunately, 0.31 is the current 'agreed upon' standard across crates.
If we see a need to bump it, this will take some coordination effort across projects (BDK, LDK, Cashu, Fedimint, Payjoin, at the very least would be affected).
|
Changed to 0.36.0 because |
|
@tnull & @binarybaron what would you think about extracting the |
So, moving the SQLite store into an individual crate would generally be a good idea, IMO. I however don't think that it would solve the issue, at least if you don't want to go down the road of introducing features to enable individual |
Description
This PR bumps the chain crates feature dependency on rusqlite to the more recent version 0.36.0.
Notes to the reviewers
I submitted this PR because the "outdated" dependency breaks dependency resolution in my project.
See #1766
Changelog notice
Checklists
All Submissions:
New Features:
Bugfixes: